chromecast/browser/metrics/cast_metrics_service_client.cc - Issue 2774503002: Track network stack error codes from UMA and UKM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)

Patch Set: Rebase on Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc

index c0290d06e1c0fb90a61784f673bca19ae2d63ed6..69bbf454f56b6197ad3e039c82d3306d89b97e71 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.cc

+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc

@@ -253,7 +253,7 @@ CastMetricsServiceClient::CreateUploader(

base::StringPiece server_url,

base::StringPiece mime_type,

::metrics::MetricsLogUploader::MetricServiceType service_type,

- const base::Callback<void(int)>& on_upload_complete) {

+ const ::metrics::MetricsLogUploader::UploadCallback& on_upload_complete) {

return std::unique_ptr<::metrics::MetricsLogUploader>(

new ::metrics::NetMetricsLogUploader(request_context_, server_url,

mime_type, service_type,