Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: android_webview/native/aw_metrics_log_uploader.cc

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)
Patch Set: Rebase on Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_metrics_log_uploader.cc
diff --git a/android_webview/native/aw_metrics_log_uploader.cc b/android_webview/native/aw_metrics_log_uploader.cc
index 3e47f1ae426a1047298ad2c0f49fbc262fa158a1..fb714b8b1a42fa0f284609cc1bc120b01e1b8e4a 100644
--- a/android_webview/native/aw_metrics_log_uploader.cc
+++ b/android_webview/native/aw_metrics_log_uploader.cc
@@ -14,7 +14,7 @@ using base::android::ToJavaByteArray;
namespace android_webview {
AwMetricsLogUploader::AwMetricsLogUploader(
- const base::Callback<void(int)>& on_upload_complete)
+ const metrics::MetricsLogUploader::UploadCallback& on_upload_complete)
: on_upload_complete_(on_upload_complete) {}
AwMetricsLogUploader::~AwMetricsLogUploader() {}
@@ -27,7 +27,7 @@ void AwMetricsLogUploader::UploadLog(const std::string& compressed_log_data,
std::string log_data;
if (!metrics::DecodeLogData(compressed_log_data, &log_data)) {
// If the log is corrupt, pretend the server rejected it (HTTP Bad Request).
- on_upload_complete_.Run(400);
+ on_upload_complete_.Run(400, 0);
return;
}
@@ -38,8 +38,8 @@ void AwMetricsLogUploader::UploadLog(const std::string& compressed_log_data,
// The platform mechanism doesn't provide a response code or any way to handle
// failures, so we have nothing to pass to on_upload_complete. Just pass 200
- // (HTTP OK) and pretend everything is peachy.
- on_upload_complete_.Run(200);
+ // (HTTP OK) with error code 0 and pretend everything is peachy.
+ on_upload_complete_.Run(200, 0);
}
} // namespace android_webview
« no previous file with comments | « android_webview/native/aw_metrics_log_uploader.h ('k') | android_webview/native/aw_metrics_service_client_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698