Revert "Move files in wtf/ to platform/wtf/"

Revert "Move files in wtf/ to platform/wtf/"

This reverts 2 CLs:
https://codereview.chromium.org/2771783003
https://codereview.chromium.org/2767153004

Compilation on Windows was broken after r459386 if is_component_build=true.
[6/3401] LINK(DLL) blink_platform.dll blink_platform.dll.lib blink_platform.dll.pdb
FAILED: blink_platform.dll blink_platform.dll.lib blink_platform.dll.pdb
C:/python_27_amd64/files/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./blink_platform.dll.lib /DLL /OUT:./blink_platform.dll /PDB:./blink_platform.dll.pdb @./blink_platform.dll.rsp
LINK : fatal error LNK1104: cannot open file 'wtf.dll.lib'
[55/3401] CXX irt_x64/obj/third_party/icu/icui18n/tzfmt.o
ninja: build stopped: subcommand failed.

'wtf.dll.lib' isn't created because it doesn't contain any symbols to export.


BUG=691465
TBR=yutak@chromium.org

Review-Url: https://codereview.chromium.org/2774333002
Cr-Commit-Position: refs/heads/master@{#459796}
Committed: https://chromium.googlesource.com/chromium/src/+/9cd48d5cbc285e39f3a6401ecd40134e0f2d5bc7

[vasilii, 2017-03-27 13:58:51]

vasilii@chromium.org changed reviewers:
+ kolos@chromium.org

[vasilii, 2017-03-27 13:58:52]

Maxim, please review

[kolos1, 2017-03-27 14:00:35]

LGTM. Thanks Vasilii for fixing it!

[kolos1, 2017-03-27 14:00:43]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2017-03-27 14:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-27 15:25:30]

LGTM

[commit-bot: I haz the power, 2017-03-27 16:20:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490623243340570, "parent_rev":
"82140202ac1fac6fe0cba1b3504a83767638f520", "commit_rev":
"9cd48d5cbc285e39f3a6401ecd40134e0f2d5bc7"}

[commit-bot: I haz the power, 2017-03-27 16:21:53]

Description was changed from

==========
Revert "Move files in wtf/ to platform/wtf/"

This reverts 2 CLs:
https://codereview.chromium.org/2771783003
https://codereview.chromium.org/2767153004

Compilation on Windows was broken after r459386 if is_component_build=true.
[6/3401] LINK(DLL) blink_platform.dll blink_platform.dll.lib
blink_platform.dll.pdb
FAILED: blink_platform.dll blink_platform.dll.lib blink_platform.dll.pdb
C:/python_27_amd64/files/python.exe ../../build/toolchain/win/tool_wrapper.py
link-wrapper environment.x64 False link.exe /nologo
/IMPLIB:./blink_platform.dll.lib /DLL /OUT:./blink_platform.dll
/PDB:./blink_platform.dll.pdb @./blink_platform.dll.rsp
LINK : fatal error LNK1104: cannot open file 'wtf.dll.lib'
[55/3401] CXX irt_x64/obj/third_party/icu/icui18n/tzfmt.o
ninja: build stopped: subcommand failed.

'wtf.dll.lib' isn't created because it doesn't contain any symbols to export.


BUG=691465
TBR=yutak@chromium.org
==========

to

==========
Revert "Move files in wtf/ to platform/wtf/"

This reverts 2 CLs:
https://codereview.chromium.org/2771783003
https://codereview.chromium.org/2767153004

Compilation on Windows was broken after r459386 if is_component_build=true.
[6/3401] LINK(DLL) blink_platform.dll blink_platform.dll.lib
blink_platform.dll.pdb
FAILED: blink_platform.dll blink_platform.dll.lib blink_platform.dll.pdb
C:/python_27_amd64/files/python.exe ../../build/toolchain/win/tool_wrapper.py
link-wrapper environment.x64 False link.exe /nologo
/IMPLIB:./blink_platform.dll.lib /DLL /OUT:./blink_platform.dll
/PDB:./blink_platform.dll.pdb @./blink_platform.dll.rsp
LINK : fatal error LNK1104: cannot open file 'wtf.dll.lib'
[55/3401] CXX irt_x64/obj/third_party/icu/icui18n/tzfmt.o
ninja: build stopped: subcommand failed.

'wtf.dll.lib' isn't created because it doesn't contain any symbols to export.


BUG=691465
TBR=yutak@chromium.org

Review-Url: https://codereview.chromium.org/2774333002
Cr-Commit-Position: refs/heads/master@{#459796}
Committed:
https://chromium.googlesource.com/chromium/src/+/9cd48d5cbc285e39f3a6401ecd40...
==========

[commit-bot: I haz the power, 2017-03-27 16:21:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9cd48d5cbc285e39f3a6401ecd40...

[Yuta Kitamura, 2017-03-28 04:10:01]

Is there any trybot for that configuration?

[Yuta Kitamura, 2017-03-28 05:06:49]

Actually, win_chromium_compile_dbg_ng does component build and
the patch compiled successfully on that bot.

I think there's an additional requirement other than
is_component_build = true. Can you check it out?

[Yuta Kitamura, 2017-03-28 08:52:07]

I tried to build on my local Win7 desktop but the issue still
doesn't repro: I can compile and run successfully with
is_component_build = true, either on Debug or Release, and
either on MSVC or clang-cl.

I could not find a trybot that fails with my CL, either.

At this point I'm not quite sure what's happening with my CL.
Could you help me identifying a way to reproduce the issue?
Thanks!

[vasilii, 2017-03-28 09:00:26]

On 2017/03/28 05:06:49, Yuta Kitamura wrote:
> Actually, win_chromium_compile_dbg_ng does component build and
> the patch compiled successfully on that bot.
> 
> I think there's an additional requirement other than
> is_component_build = true. Can you check it out?

is_component_build = true
enable_nacl = false

Windows 10
gn gen --ide=vs --filters=//chrome out\Default

The compiler didn't generate wtf.dll.lib (only wtf.dll) while
platform_wtf.dll.lib was created.

[Yuta Kitamura, 2017-03-29 04:32:42]

On 2017/03/28 09:00:26, vasilii wrote:
> On 2017/03/28 05:06:49, Yuta Kitamura wrote:
> > Actually, win_chromium_compile_dbg_ng does component build and
> > the patch compiled successfully on that bot.
> > 
> > I think there's an additional requirement other than
> > is_component_build = true. Can you check it out?
> 
> is_component_build = true
> enable_nacl = false
> 
> Windows 10
> gn gen --ide=vs --filters=//chrome out\Default
> 
> The compiler didn't generate wtf.dll.lib (only wtf.dll) while
> platform_wtf.dll.lib was created.

Do you compile with MSVC or use ninja directly?

[Yuta Kitamura, 2017-03-29 05:01:55]

I still can't get a repro locally. On my environment (Win7),
building with ninja is OK, and the built executables run fine.
(I don't have MSVC at hand right now; I ordered one but it takes
 some time)

I uploaded a speculative fix at https://codereview.chromium.org/2776933005
(Patch Set 2). If you have time, can you test it to see if
it fixes the compile for you?