Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2776933005: Reland: Move files in wtf/ to platform/wtf/ (Part 12). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
haraken, vasilii
CC:
chromium-reviews, tzik, nhiroki, kinuko+fileapi, blink-reviews, blink-reviews-wtf_chromium.org, kinuko+watch, Mikhail, vasilii
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Move files in wtf/ to platform/wtf/ (Part 12). This relands the following patch with a fix: http://crrev.com/2767153004#ps100001 > This patch moves all the remaining files (except tests) in wtf/: > > BloomFilter.h, ByteOrder.h, DateMath.{h,cpp}, FilePrintStream.cpp, > InstanceCounter.cpp, PrintStream.cpp, RefVector.h, > SaturatedArithmetic.h, SizeLimits.cpp, StackUtil.cpp, > TerminatedArrayBuilder.h, TerminatedArray.h, > ThreadingPthreads.cpp, ThreadingWin.cpp, ThreadSpecificWin.cpp, > WTF.cpp, WTFThreadData.cpp, debug/Alias.h, debug/CrashLogging.h > > Additionally, miscellaneous documents are moved to the new location, and > debug/DEPS is copied, too. UniquePtrTransitionGuide.md isn't moved, because > the content is now mostly obsolete and it can be removed. BUG=691465 Review-Url: https://codereview.chromium.org/2776933005 Cr-Commit-Position: refs/heads/master@{#460699} Committed: https://chromium.googlesource.com/chromium/src/+/ebab42ba798f9ca51aa9ff6e84884ded2799f632

Patch Set 1 : Original patch from https://codereview.chromium.org/2767153004 #

Patch Set 2 : Speculative fix for MSVC build issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -3620 lines) Patch
A + third_party/WebKit/Source/platform/wtf/Allocator.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 6 chunks +25 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/BloomFilter.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ByteOrder.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/CONTRIBUTORS.pthreads-win32 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/DateMath.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/DateMath.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/FilePrintStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/InstanceCounter.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/PrintStream.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/RefVector.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/SaturatedArithmetic.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ScopedLogger.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/SizeLimits.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StackUtil.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TerminatedArray.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TerminatedArrayBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadingPthreads.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadingWin.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/WTF.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/WTFThreadData.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/debug/Alias.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/debug/CrashLogging.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/wtf/debug/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/wtf/Allocator.md View 1 chunk +0 lines, -186 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 6 chunks +1 line, -23 lines 0 comments Download
M third_party/WebKit/Source/wtf/BloomFilter.h View 1 chunk +7 lines, -147 lines 0 comments Download
M third_party/WebKit/Source/wtf/ByteOrder.h View 1 chunk +7 lines, -84 lines 0 comments Download
D third_party/WebKit/Source/wtf/CONTRIBUTORS.pthreads-win32 View 1 chunk +0 lines, -137 lines 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.h View 1 chunk +7 lines, -119 lines 0 comments Download
D third_party/WebKit/Source/wtf/DateMath.cpp View 1 chunk +0 lines, -842 lines 0 comments Download
A third_party/WebKit/Source/wtf/Dummy.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/wtf/FilePrintStream.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/wtf/InstanceCounter.cpp View 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/WebKit/Source/wtf/PrintStream.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefVector.h View 1 chunk +5 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/wtf/SaturatedArithmetic.h View 1 chunk +7 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/wtf/ScopedLogger.md View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/Source/wtf/SizeLimits.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/Source/wtf/StackUtil.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 chunk +5 lines, -119 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 1 chunk +5 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/wtf/ThreadSpecificWin.cpp View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 1 chunk +0 lines, -263 lines 0 comments Download
D third_party/WebKit/Source/wtf/ThreadingWin.cpp View 1 chunk +0 lines, -426 lines 0 comments Download
D third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/Source/wtf/WTFThreadData.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/wtf/debug/Alias.h View 1 chunk +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/wtf/debug/CrashLogging.h View 1 chunk +5 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
vasilii
I built the CL with ninja and it compiled fine on my Windows machine. wtf.dll.lib ...
3 years, 8 months ago (2017-03-29 10:38:26 UTC) #6
Yuta Kitamura
OK, let me try to reland this. haraken: Can you review the diff between PS1:PS2?
3 years, 8 months ago (2017-03-30 04:29:36 UTC) #8
haraken
LGTM
3 years, 8 months ago (2017-03-30 05:18:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776933005/20001
3 years, 8 months ago (2017-03-30 05:40:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ebab42ba798f9ca51aa9ff6e84884ded2799f632
3 years, 8 months ago (2017-03-30 08:46:12 UTC) #14
vasilii
3 years, 8 months ago (2017-03-30 09:56:19 UTC) #15
Message was sent while issue was closed.
It still compiles fine on the ToT on my machine.

Powered by Google App Engine
This is Rietveld 408576698