Move wtf_unittests to platform/wtf/.

Move wtf_unittests to platform/wtf/.

This patch moves all the cpp files for wtf_unittests to their new home
platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and
it's added in platform/wtf/BUILD.gn. Due to this change, a few other files
need to be updated, too.

BUG=691465
Review-Url: https://codereview.chromium.org/2771783003
Cr-Commit-Position: refs/heads/master@{#459715}
Committed: https://chromium.googlesource.com/chromium/src/+/c3434c4e95fac9bad103211dde483a42f555255a

[Yuta Kitamura, 2017-03-23 09:33:08]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 09:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 10:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 10:50:21]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Yuta Kitamura, 2017-03-24 02:58:23]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 02:58:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-03-24 03:34:23]

Description was changed from

==========
Move wtf_unittests to platform/wtf/.

This patch moves all the cpp files for wtf_unittests to their new home
platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and
it's added in platform/wtf/BUILD.gn. Due to this change, a few other files
need to be updated, too.

BUG=691465
==========

to

==========
Move wtf_unittests to platform/wtf/.

This patch moves all the cpp files for wtf_unittests to their new home
platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and
it's added in platform/wtf/BUILD.gn. Due to this change, a few other files
need to be updated, too.

BUG=691465
==========

[Yuta Kitamura, 2017-03-24 03:34:23]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuta Kitamura, 2017-03-24 03:35:49]

haraken: This is the final piece of bulk move -- PTAL?

I'll ask individual OWNERS later for the files not covered
by me/you.

[haraken, 2017-03-24 03:44:07]

LGTM

[commit-bot: I haz the power, 2017-03-24 04:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:28:07]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Yuta Kitamura, 2017-03-24 06:53:02]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 06:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-03-24 08:04:14]

yutak@chromium.org changed reviewers:
+ thakis@chromium.org

[Yuta Kitamura, 2017-03-24 08:04:15]

thakis: Can you give me an approval for the following files?

    BUILD.gn (directly under src/)
    third_party/WebKit/public/BUILD.gn
    testing/buildbot/gn_isolate_map.pyl

No rush, because I need to land a few depending patches
first. Thanks!

[commit-bot: I haz the power, 2017-03-24 08:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 08:24:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2017-03-24 11:16:13]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 11:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:05:37]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-24 14:28:49]

lgtm

[Nico, 2017-03-24 14:30:40]

https://codereview.chromium.org/2771783003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/wtf/BUILD.gn (right):

https://codereview.chromium.org/2771783003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/wtf/BUILD.gn:281: defines = [
"WTF_IMPLEMENTATION=1" ]
FYI, I see possibly trouble with this. Both platform_wtf and wtf set
WTF_IMPLEMENTATION, so if a platform_wtf file includes a wtf header (or the
other way round), WTF_EXPORT will turn to an export for both the wtf header and
the platform_wtf file, so platform_wtf will export both platform_wtf and wtf
symbols.

[Yuta Kitamura, 2017-03-27 04:03:49]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2017-03-27 04:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2771783003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-27 04:04:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 04:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 04:56:59]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuta Kitamura, 2017-03-27 06:51:21]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:51:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 07:48:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490597481363800,
"parent_rev": "fde595e0f1b0fe737bd7c0c6e3c196da75ccf20d", "commit_rev":
"c3434c4e95fac9bad103211dde483a42f555255a"}

[commit-bot: I haz the power, 2017-03-27 07:49:01]

Description was changed from

==========
Move wtf_unittests to platform/wtf/.

This patch moves all the cpp files for wtf_unittests to their new home
platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and
it's added in platform/wtf/BUILD.gn. Due to this change, a few other files
need to be updated, too.

BUG=691465
==========

to

==========
Move wtf_unittests to platform/wtf/.

This patch moves all the cpp files for wtf_unittests to their new home
platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and
it's added in platform/wtf/BUILD.gn. Due to this change, a few other files
need to be updated, too.

BUG=691465

Review-Url: https://codereview.chromium.org/2771783003
Cr-Commit-Position: refs/heads/master@{#459715}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3434c4e95fac9bad103211dde48...
==========

[commit-bot: I haz the power, 2017-03-27 07:49:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c3434c4e95fac9bad103211dde48...

[Yuta Kitamura, 2017-03-27 08:38:16]

On 2017/03/24 14:30:40, Nico wrote:
>
https://codereview.chromium.org/2771783003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/wtf/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2771783003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/wtf/BUILD.gn:281: defines = [
> "WTF_IMPLEMENTATION=1" ]
> FYI, I see possibly trouble with this. Both platform_wtf and wtf set
> WTF_IMPLEMENTATION, so if a platform_wtf file includes a wtf header (or the
> other way round), WTF_EXPORT will turn to an export for both the wtf header
and
> the platform_wtf file, so platform_wtf will export both platform_wtf and wtf
> symbols.

I think it's proooooobably OK because there's no .cpp file in
wtf at this point (wtf uses no symbols from platform_wtf, and
no symbols are defined in wtf). I saw errors caused by
export/import issues in the past, and dealing with that was tricky...

[kolos1, 2017-03-27 14:52:02]

Reverting this CL, see https://codereview.chromium.org/2774333002/