Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2743)

Unified Diff: chrome/browser/resources/md_bookmarks/dnd_manager.js

Issue 2774233006: [MD Bookmarks] Change selection items from Map to Set. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/app.js ('k') | chrome/browser/resources/md_bookmarks/folder_node.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/dnd_manager.js
diff --git a/chrome/browser/resources/md_bookmarks/dnd_manager.js b/chrome/browser/resources/md_bookmarks/dnd_manager.js
index b5273e976816f820cbaeb8dae1c86ec17866050b..2f590a60674bf938cdadff5c05098f2f46900077 100644
--- a/chrome/browser/resources/md_bookmarks/dnd_manager.js
+++ b/chrome/browser/resources/md_bookmarks/dnd_manager.js
@@ -328,7 +328,7 @@ cr.define('bookmarks', function() {
// Determine the selected bookmarks.
var state = bookmarks.Store.getInstance().data;
- var draggedNodes = Object.keys(state.selection.items);
+ var draggedNodes = Array.from(state.selection.items);
if (isBookmarkFolderNode(dragElement) ||
draggedNodes.indexOf(dragElement.itemId) == -1) {
@@ -496,7 +496,7 @@ cr.define('bookmarks', function() {
// Don't allow dropping below an expanded sidebar folder item since it is
// confusing to the user anyway.
- if (isOverFolderNode && !state.closedFolders[overElement.itemId] &&
+ if (isOverFolderNode && !state.closedFolders.has(overElement.itemId) &&
bookmarks.util.hasChildFolders(overElement.itemId, state.nodes)) {
return validDropPositions;
}
« no previous file with comments | « chrome/browser/resources/md_bookmarks/app.js ('k') | chrome/browser/resources/md_bookmarks/folder_node.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698