Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2774223005:
Enable -Wshift-negative-value. (Closed)
DescriptionEnable -Wshift-negative-value.
But not on chromeos, since it uses the old libjpeg were this isn't fixed yet.
BUG=507717
Review-Url: https://codereview.chromium.org/2774223005
Cr-Commit-Position: refs/heads/master@{#460989}
Committed: https://chromium.googlesource.com/chromium/src/+/e28bd95d56cc19730ccc89f3bd8d8db47b7ef502
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : sandbox #
Total comments: 1
Patch Set 4 : not on cros #
Messages
Total messages: 33 (22 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Description was changed from ========== try -Wshift-negative-value . BUG= ========== to ========== Enable -Wshift-negative-value. BUG=507717 ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + dcheng@chromium.org, jln@chromium.org, primiano@chromium.org
jln: linux/sandbox primiano: tcmalloc dcheng: build
//build lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CQ has no permission to schedule in bucket master.tryserver.chromium.linux
I guess an attempt of rolling clang found some new undefined behavior there? Mild shock :P Allocator lgtm
On 2017/03/28 21:20:55, Primiano Tucci wrote: > I guess an attempt of rolling clang found some new undefined behavior there? > Mild shock :P > Allocator lgtm No, someone happened to fix what I thought was the last blocker for this one yesterday (https://bugs.chromium.org/p/chromium/issues/detail?id=507712#c8).
thakis@chromium.org changed reviewers: + rsesek@chromium.org - jln@chromium.org
+rsesek for sandbox/linux
https://codereview.chromium.org/2774223005/diff/40001/sandbox/linux/BUILD.gn File sandbox/linux/BUILD.gn (right): https://codereview.chromium.org/2774223005/diff/40001/sandbox/linux/BUILD.gn#... sandbox/linux/BUILD.gn:152: # TODO(thakis): Fix that in LSS, then remove this flag here. rsesek: I actually tried to do this so I'm not blocked on linux/sandbox/OWNERS review, but ran into problems rolling LSS, see https://bugs.chromium.org/p/chromium/issues/detail?id=507717#c13
LGTM
Description was changed from ========== Enable -Wshift-negative-value. BUG=507717 ========== to ========== Enable -Wshift-negative-value. But not on chromeos, since it uses the old libjpeg were this isn't fixed yet. BUG=507717 ==========
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, rsesek@chromium.org, dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2774223005/#ps60001 (title: "not on cros")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490918227946710,
"parent_rev": "6e2566025380bdaff5d9f9da38f253a626fd2cfa", "commit_rev":
"e28bd95d56cc19730ccc89f3bd8d8db47b7ef502"}
Message was sent while issue was closed.
Description was changed from ========== Enable -Wshift-negative-value. But not on chromeos, since it uses the old libjpeg were this isn't fixed yet. BUG=507717 ========== to ========== Enable -Wshift-negative-value. But not on chromeos, since it uses the old libjpeg were this isn't fixed yet. BUG=507717 Review-Url: https://codereview.chromium.org/2774223005 Cr-Commit-Position: refs/heads/master@{#460989} Committed: https://chromium.googlesource.com/chromium/src/+/e28bd95d56cc19730ccc89f3bd8d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/e28bd95d56cc19730ccc89f3bd8d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
