Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: base/allocator/BUILD.gn

Issue 2774223005: Enable -Wshift-negative-value. (Closed)
Patch Set: not on cros Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/allocator.gni") 6 import("//build/config/allocator.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Provide a way to force disable debugallocation in Debug builds, 10 # Provide a way to force disable debugallocation in Debug builds,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 # tcmalloc contains some unused local template specializations. 65 # tcmalloc contains some unused local template specializations.
66 "-Wno-unused-function", 66 "-Wno-unused-function",
67 67
68 # tcmalloc uses COMPILE_ASSERT without static_assert but with 68 # tcmalloc uses COMPILE_ASSERT without static_assert but with
69 # typedefs. 69 # typedefs.
70 "-Wno-unused-local-typedefs", 70 "-Wno-unused-local-typedefs",
71 71
72 # for magic2_ in debugallocation.cc (only built in Debug builds) 72 # for magic2_ in debugallocation.cc (only built in Debug builds)
73 # typedefs. 73 # typedefs.
74 "-Wno-unused-private-field", 74 "-Wno-unused-private-field",
75
76 # base/basictypes.h's kint64min definition shifts a negative value around,
77 # which is undefined behavior. TODO(thakis): Try to get that fixed.
78 "-Wno-shift-negative-value",
75 ] 79 ]
76 } else { 80 } else {
77 cflags = [] 81 cflags = []
78 } 82 }
79 83
80 if (is_linux || is_android) { 84 if (is_linux || is_android) {
81 # We enable all warnings by default, but upstream disables a few. 85 # We enable all warnings by default, but upstream disables a few.
82 # Keep "-Wno-*" flags in sync with upstream by comparing against: 86 # Keep "-Wno-*" flags in sync with upstream by comparing against:
83 # http://code.google.com/p/google-perftools/source/browse/trunk/Makefile.am 87 # http://code.google.com/p/google-perftools/source/browse/trunk/Makefile.am
84 cflags += [ 88 cflags += [
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 "-Wl,-wrap,calloc", 304 "-Wl,-wrap,calloc",
301 "-Wl,-wrap,free", 305 "-Wl,-wrap,free",
302 "-Wl,-wrap,malloc", 306 "-Wl,-wrap,malloc",
303 "-Wl,-wrap,memalign", 307 "-Wl,-wrap,memalign",
304 "-Wl,-wrap,posix_memalign", 308 "-Wl,-wrap,posix_memalign",
305 "-Wl,-wrap,pvalloc", 309 "-Wl,-wrap,pvalloc",
306 "-Wl,-wrap,realloc", 310 "-Wl,-wrap,realloc",
307 "-Wl,-wrap,valloc", 311 "-Wl,-wrap,valloc",
308 ] 312 ]
309 } 313 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698