Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: base/allocator/BUILD.gn

Issue 2774223005: Enable -Wshift-negative-value. (Closed)
Patch Set: not on cros Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/BUILD.gn
diff --git a/base/allocator/BUILD.gn b/base/allocator/BUILD.gn
index 8cdb06161f5c23afb34058f71a449024c5a93d54..4fe226c9b8bbcda4e2dc372e0a23e84329a19d89 100644
--- a/base/allocator/BUILD.gn
+++ b/base/allocator/BUILD.gn
@@ -72,6 +72,10 @@ config("tcmalloc_flags") {
# for magic2_ in debugallocation.cc (only built in Debug builds)
# typedefs.
"-Wno-unused-private-field",
+
+ # base/basictypes.h's kint64min definition shifts a negative value around,
+ # which is undefined behavior. TODO(thakis): Try to get that fixed.
+ "-Wno-shift-negative-value",
]
} else {
cflags = []
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698