Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Issue 2773533002: Add a progress indicator to the VR omnibox (Closed)

Created:
3 years, 9 months ago by cjgrant
Modified:
3 years, 9 months ago
Reviewers:
mthiesse, tiborg
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a progress indicator to the VR omnibox The current UX thinking is that the URL indicator (visible transiently on navigations), and the omnibox, are distict elements that share some visual similarity. Mirror the URL indicator's progress-indicating border on the omnibox, so that there's visible loading progress in the menu. Even if we decide that all menu-driven navigations immediately exit the menu, the user may still pop back into the menu during loading. BUG=687960 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2773533002 Cr-Commit-Position: refs/heads/master@{#459257} Committed: https://chromium.googlesource.com/chromium/src/+/30fc05395028eb75715e994406397463341e54da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -17 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.css View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.html View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 5 chunks +41 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
cjgrant
Replicate the loading-progress border from the URL indicator on the Omnibox. Only one of these ...
3 years, 9 months ago (2017-03-22 21:29:15 UTC) #3
mthiesse
lgtm
3 years, 9 months ago (2017-03-23 21:05:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773533002/1
3 years, 9 months ago (2017-03-23 21:16:59 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 22:29:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30fc05395028eb75715e99440639...

Powered by Google App Engine
This is Rietveld 408576698