Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2764373002: Incorporate VR UI styling changes (Closed)

Created:
3 years, 9 months ago by cjgrant
Modified:
3 years, 9 months ago
Reviewers:
mthiesse, tiborg
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Incorporate VR UI styling changes The modifications in this CL are taken from joshcarpenter1@'s CL 2694313002, merged to ToT, and pared back slightly where the CL would have broken behavior or looked odd in the current UI. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2764373002 Cr-Commit-Position: refs/heads/master@{#458862} Committed: https://chromium.googlesource.com/chromium/src/+/18a53e754e600563cd1e85c23e90e44e44fde799

Patch Set 1 #

Patch Set 2 : Additional stylistic tweaks and cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -51 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.css View 1 7 chunks +32 lines, -23 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 14 chunks +50 lines, -28 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
cjgrant
Folks, as per the description, this CL is Josh's UI style cleanup CL, rebased and ...
3 years, 9 months ago (2017-03-22 17:15:18 UTC) #3
mthiesse
lgtm
3 years, 9 months ago (2017-03-22 18:39:05 UTC) #4
tiborg
lgtm
3 years, 9 months ago (2017-03-22 19:17:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764373002/20001
3 years, 9 months ago (2017-03-22 19:25:10 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 20:35:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18a53e754e600563cd1e85c23e90...

Powered by Google App Engine
This is Rietveld 408576698