Ensure VR UI does not miss controller button clicks

Ensure VR UI does not miss controller button clicks

The controller state was being collected at a point that doesn't map 1:1
with UI input handling.  This meant that occasionally, a button event
could be seen twice, or not at all, by the UI.

BUG=None

Review-Url: https://codereview.chromium.org/2768133003
Cr-Commit-Position: refs/heads/master@{#459422}
Committed: https://chromium.googlesource.com/chromium/src/+/d6812967f11d73152f79e9b29108389cfd382a21

[cjgrant, 2017-03-23 21:24:46]

cjgrant@chromium.org changed reviewers:
+ klausw@chromium.org, mthiesse@chromium.org

[cjgrant, 2017-03-23 21:24:47]

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (left):

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:497: return;
I'm not sure why we were returning here.

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:533: // Note that button up/down
state is transient, so ButtonDownHappened only
Broken out to a function for readability.

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:514: if (ShouldDrawWebVr()) {
On second thought, this is bad, and I'll revert this check.

[mthiesse, 2017-03-23 21:34:23]

lgtm

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (left):

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:497: return;
On 2017/03/23 21:24:47, cjgrant wrote:
> I'm not sure why we were returning here.

Fine to remove, as long as the check below stays.

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:514: if (ShouldDrawWebVr()) {
On 2017/03/23 21:24:47, cjgrant wrote:
> On second thought, this is bad, and I'll revert this check.

On third thought, don't revert this check.

[cjgrant, 2017-03-23 21:35:35]

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2768133003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:514: if (ShouldDrawWebVr()) {
On 2017/03/23 21:24:47, cjgrant wrote:
> On second thought, this is bad, and I'll revert this check.

On third thought, lets keep this, as it moves the original return down here. 
However, the fact that we early-return at all is a bug - we can have UI elements
with active mouse activity over them, and when we return to "drawing webvr", we
need to send "mouse is gone" events.

I don't know how big a deal this will actually be, since we're only now letting
people pop between webvr and menu with the app button.  I'll file a bug for this
too.

[cjgrant, 2017-03-24 14:08:47]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:09:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:44:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490364527522570, "parent_rev":
"c48f6533dbd721f4401bf82b6f7ccc4e760da9d4", "commit_rev":
"d6812967f11d73152f79e9b29108389cfd382a21"}

[commit-bot: I haz the power, 2017-03-24 14:45:13]

Description was changed from

==========
Ensure VR UI does not miss controller button clicks

The controller state was being collected at a point that doesn't map 1:1
with UI input handling.  This meant that occasionally, a button event
could be seen twice, or not at all, by the UI.

BUG=None
==========

to

==========
Ensure VR UI does not miss controller button clicks

The controller state was being collected at a point that doesn't map 1:1
with UI input handling.  This meant that occasionally, a button event
could be seen twice, or not at all, by the UI.

BUG=None

Review-Url: https://codereview.chromium.org/2768133003
Cr-Commit-Position: refs/heads/master@{#459422}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6812967f11d73152f79e9b29108...
==========

[commit-bot: I haz the power, 2017-03-24 14:45:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6812967f11d73152f79e9b29108...