Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2769353004: Fix build break on Mac SDK 10.12. (Closed)

Created:
3 years, 9 months ago by Avi (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
lanwei
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build break on Mac SDK 10.12. BUG=705176, 685252 Review-Url: https://codereview.chromium.org/2769353004 Cr-Commit-Position: refs/heads/master@{#459686} Committed: https://chromium.googlesource.com/chromium/src/+/3c1d1f31c293867ecd7f90d60419e5a13d503408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 3 chunks +9 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 9 months ago (2017-03-25 01:03:42 UTC) #4
lanwei
On 2017/03/25 01:03:42, Avi wrote: LGTM, thanks! Sorry, I thought it also takes an enum ...
3 years, 9 months ago (2017-03-27 00:58:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769353004/1
3 years, 9 months ago (2017-03-27 00:58:40 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 01:19:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c1d1f31c293867ecd7f90d60419...

Powered by Google App Engine
This is Rietveld 408576698