content/browser/frame_host/frame_tree_node.cc - Issue 2773403002: Fix popunders spawned from a subframe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 2773403002: Fix popunders spawned from a subframe. (Closed)

Patch Set: alex Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree_node.cc

diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc

index 288bcec994a48e09dc19365d4089f1282fd9d132..cb345e3cc159f2ad302d3e95a379b6b6d8e80344 100644

--- a/content/browser/frame_host/frame_tree_node.cc

+++ b/content/browser/frame_host/frame_tree_node.cc

@@ -227,6 +227,7 @@ void FrameTreeNode::SetOpener(FrameTreeNode* opener) {

void FrameTreeNode::SetOriginalOpener(FrameTreeNode* opener) {

DCHECK(!original_opener_ || !opener);

+ DCHECK(opener == nullptr || !opener->parent());

original_opener_ = opener;