AXObject::performDefaultAction() should focus if it can't click

AXObject::performDefaultAction() should focus if it can't click

The user-visible bug here is that sending a CLICK event to a text field on
Android does nothing, because a text field doesn't have a default action.

I could fix this on the Android side, but this seems wrong to me. If
performDefaultAction() is called on a focusable control, I think the natural
thing to do is focus it if there's no "press" behavior. So I think we should
handle that generally.

Let me know if you have any objection and I could make it more narrow. But to
me it seems more useful this way.

BUG=703659
Review-Url: https://codereview.chromium.org/2772913003
Cr-Commit-Position: refs/heads/master@{#459448}
Committed: https://chromium.googlesource.com/chromium/src/+/cbf2ebc6e589a5aa81d29c78cf392182de4329bb

[dmazzoni, 2017-03-23 23:31:43]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-03-23 23:32:12]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org, nektar@chromium.org

[dmazzoni, 2017-03-23 23:32:13]

Alice or Nektarios, any thoughts on this?

[commit-bot: I haz the power, 2017-03-23 23:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nektarios, 2017-03-24 01:49:29]

I agree. That's why I would have preferred if the method was called Activate
instead of DoDefaultAction. Then, there would be no confusion in these kinds of
situations.
Activating a text field means putting focus in it.
Activating a pop-up menu means expanding it.

[nektarios, 2017-03-24 01:49:36]

lgtm

[commit-bot: I haz the power, 2017-03-24 01:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:55:31]

Dry run: This issue passed the CQ dry run.

[aboxhall, 2017-03-24 04:39:21]

+1 lgtm 

On 2017/03/24 01:49:36, nektarios wrote:
> lgtm

[dmazzoni, 2017-03-24 16:14:40]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:15:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:22:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490372080520510,
"parent_rev": "db3faa30e037243df62012867827b4a19289957a", "commit_rev":
"cbf2ebc6e589a5aa81d29c78cf392182de4329bb"}

[commit-bot: I haz the power, 2017-03-24 16:23:06]

Description was changed from

==========
AXObject::performDefaultAction() should focus if it can't click

The user-visible bug here is that sending a CLICK event to a text field on
Android does nothing, because a text field doesn't have a default action.

I could fix this on the Android side, but this seems wrong to me. If
performDefaultAction() is called on a focusable control, I think the natural
thing to do is focus it if there's no "press" behavior. So I think we should
handle that generally.

Let me know if you have any objection and I could make it more narrow. But to
me it seems more useful this way.

BUG=703659
==========

to

==========
AXObject::performDefaultAction() should focus if it can't click

The user-visible bug here is that sending a CLICK event to a text field on
Android does nothing, because a text field doesn't have a default action.

I could fix this on the Android side, but this seems wrong to me. If
performDefaultAction() is called on a focusable control, I think the natural
thing to do is focus it if there's no "press" behavior. So I think we should
handle that generally.

Let me know if you have any objection and I could make it more narrow. But to
me it seems more useful this way.

BUG=703659

Review-Url: https://codereview.chromium.org/2772913003
Cr-Commit-Position: refs/heads/master@{#459448}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbf2ebc6e589a5aa81d29c78cf39...
==========

[commit-bot: I haz the power, 2017-03-24 16:23:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cbf2ebc6e589a5aa81d29c78cf39...