third_party/WebKit/Source/modules/accessibility/AXSpinButton.h - Issue 2772913003: AXObject::performDefaultAction() should focus if it can't click

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

Issue 2772913003: AXObject::performDefaultAction() should focus if it can't click (Closed)

Patch Set: Add test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h b/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

index 3ac5f01b6b73b190b4e3d3cf50bb6e49bed344dc..6e48ed646ff643d5a7269f7af1f6f2a8fbf11095 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

@@ -70,7 +70,7 @@ class AXSpinButtonPart final : public AXMockObject {

explicit AXSpinButtonPart(AXObjectCacheImpl&);

bool m_isIncrementor : 1;

- bool press() const override;

+ bool press() override;

AccessibilityRole roleValue() const override { return ButtonRole; }

bool isSpinButtonPart() const override { return true; }

void getRelativeBounds(AXObject** outContainer,