third_party/WebKit/Source/modules/accessibility/AXObject.h - Issue 2772913003: AXObject::performDefaultAction() should focus if it can't click

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.h

Issue 2772913003: AXObject::performDefaultAction() should focus if it can't click (Closed)

Patch Set: Add test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.h b/third_party/WebKit/Source/modules/accessibility/AXObject.h

index e6f2b232ae064b9f8af1a7b1aace3b7c59413133..ac9b47f066320ea2c1afdc63ffd26cbba32f476e 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.h

@@ -994,8 +994,8 @@ class MODULES_EXPORT AXObject : public GarbageCollectedFinalized<AXObject> {

// Modify or take an action on an object.

virtual void increment() {}

virtual void decrement() {}

- bool performDefaultAction() const { return press(); }

- virtual bool press() const;

+ bool performDefaultAction() { return press(); }

+ virtual bool press();

// Make this object visible by scrolling as many nested scrollable views as

// needed.

void scrollToMakeVisible() const;