Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2772843003: Compile more files app targets in gyp v2 (4) (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more files app targets in gyp v2 (4) BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2772843003 Cr-Commit-Position: refs/heads/master@{#459923} Committed: https://chromium.googlesource.com/chromium/src/+/6c18543914d549e025ef4200e25e09945eac692d

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -28 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 2 2 chunks +21 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 2 3 4 2 chunks +46 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
oka
.
3 years, 9 months ago (2017-03-24 06:02:54 UTC) #2
oka
.
3 years, 9 months ago (2017-03-24 06:05:00 UTC) #3
oka
PTAL.
3 years, 9 months ago (2017-03-24 06:05:32 UTC) #5
fukino
lgtm
3 years, 9 months ago (2017-03-24 06:15:23 UTC) #6
oka
.
3 years, 9 months ago (2017-03-24 08:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772843003/80001
3 years, 9 months ago (2017-03-27 22:20:58 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 23:05:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6c18543914d549e025ef4200e25e...

Powered by Google App Engine
This is Rietveld 408576698