Skip checking non-emptiness of username on In-Page Navigation.

Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and as result history.pushState trigger does not work for change password forms and this is one of main reason of so low coverage on change password forms.

BUG=None

Review-Url: https://codereview.chromium.org/2772793002
Cr-Commit-Position: refs/heads/master@{#459393}
Committed: https://chromium.googlesource.com/chromium/src/+/dab7db2dbb20d3c8460c54fb49e92878b800cc88

[dvadym, 2017-03-23 12:25:23]

Description was changed from

==========
Skip checking non-emptiness of username on In-Page Navigation.


BUG=None
==========

to

==========
Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and
as result history.pushState trigger is not working for change password form and
this is one of main reason so low coverage on change password forms.

BUG=None
==========

[dvadym, 2017-03-23 12:35:34]

Description was changed from

==========
Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and
as result history.pushState trigger is not working for change password form and
this is one of main reason so low coverage on change password forms.

BUG=None
==========

to

==========
Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and
as result history.pushState trigger does not work for change password forms and
this is one of main reason of so low coverage on change password forms.

BUG=None
==========

[dvadym, 2017-03-23 12:35:34]

dvadym@chromium.org changed reviewers:
+ vabr@chromium.org

[dvadym, 2017-03-23 12:36:59]

Hi Vaclav,

 could you please review this CL?

Regards,
Vadym

[dvadym, 2017-03-23 12:37:09]

https://codereview.chromium.org/2772793002/diff/1/components/autofill/content...
File components/autofill/content/renderer/form_autofill_util.h (left):

https://codereview.chromium.org/2772793002/diff/1/components/autofill/content...
components/autofill/content/renderer/form_autofill_util.h:93: // implemented on
Mac and Android.
This comment is obsolete, implementation of IsFormVisible was updated Mac and
Android a long time ago.

[vabr (Chromium), 2017-03-23 20:09:31]

LGTM.

Thanks!
Vaclav

https://codereview.chromium.org/2772793002/diff/1/components/autofill/content...
File components/autofill/content/renderer/form_autofill_util.h (left):

https://codereview.chromium.org/2772793002/diff/1/components/autofill/content...
components/autofill/content/renderer/form_autofill_util.h:93: // implemented on
Mac and Android.
On 2017/03/23 12:37:09, dvadym wrote:
> This comment is obsolete, implementation of IsFormVisible was updated Mac and
> Android a long time ago.

Acknowledged.

[dvadym, 2017-03-24 09:25:09]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:32:34]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dvadym, 2017-03-24 11:01:19]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-03-24 11:01:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 11:46:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490353279012430, "parent_rev":
"bf4de3ff1c10a7ca6b1c4ca00451165f18fa1eef", "commit_rev":
"dab7db2dbb20d3c8460c54fb49e92878b800cc88"}

[commit-bot: I haz the power, 2017-03-24 11:47:11]

Description was changed from

==========
Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and
as result history.pushState trigger does not work for change password forms and
this is one of main reason of so low coverage on change password forms.

BUG=None
==========

to

==========
Skip checking non-emptiness of username on In-Page Navigation.

This check is left from times when there was no change password form support and
as result history.pushState trigger does not work for change password forms and
this is one of main reason of so low coverage on change password forms.

BUG=None

Review-Url: https://codereview.chromium.org/2772793002
Cr-Commit-Position: refs/heads/master@{#459393}
Committed:
https://chromium.googlesource.com/chromium/src/+/dab7db2dbb20d3c8460c54fb49e9...
==========

[commit-bot: I haz the power, 2017-03-24 11:47:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dab7db2dbb20d3c8460c54fb49e9...