Skip checking non-emptiness of username on In-Page Navigation.

components/autofill/content/renderer/form_autofill_util.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_
 
 #include <stddef.h>
 
 #include <vector>
@@ skipping 68 matching lines @@
 // ref portions of URL
 GURL StripAuthAndParams(const GURL& gurl);
 
 // Extract FormData from the form element and return whether the operation was
 // successful.
 bool ExtractFormData(const blink::WebFormElement& form_element, FormData* data);
 
 // Helper function to check if there exist any visible form on |frame| which
 // equals |form_element|. If |form_element| is null, checks if forms action
 // equals |action|. Returns true if so. For forms with empty or unspecified
-// actions, all form data are used for comparison. Form data comparison is
-// disabled on Mac and Android because the update prompt isn't implemented. It
-// may cause many false password updates.
-// TODO(kolos) Turn on all data comparing when the update prompt will be
-// implemented on Mac and Android.

[dvadym, 2017/03/23 12:37:09]

This comment is obsolete, implementation of IsFormVisible was updated Mac and
Android a long time ago.

[vabr (Chromium), 2017/03/23 20:09:30]

Acknowledged.

+// actions, all form data are used for comparison.
 bool IsFormVisible(blink::WebFrame* frame,
                    const blink::WebFormElement& form_element,
                    const GURL& action,
                    const GURL& origin,
                    const FormData& form_data);
 
 // Returns true if at least one element from |control_elements| is visible.
 bool IsSomeControlElementVisible(
     const blink::WebVector<blink::WebFormControlElement>& control_elements);
 
@@ skipping 170 matching lines @@
 // |input_element|. Note that |user_input| cannot be easily derived from
 // |input_element| by calling value(), because of http://crbug.com/507714.
 void PreviewSuggestion(const base::string16& suggestion,
                        const base::string16& user_input,
                        blink::WebFormControlElement* input_element);
 
 }  // namespace form_util
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_