Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/autofill/content/renderer/form_autofill_util.h

Issue 2772793002: Skip checking non-emptiness of username on In-Page Navigation. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_autofill_util.h
diff --git a/components/autofill/content/renderer/form_autofill_util.h b/components/autofill/content/renderer/form_autofill_util.h
index 2a5ef139c9a57283af12fbcfc390b3586a090f69..9b96302b0665f96522da2326e0c9337021155481 100644
--- a/components/autofill/content/renderer/form_autofill_util.h
+++ b/components/autofill/content/renderer/form_autofill_util.h
@@ -86,11 +86,7 @@ bool ExtractFormData(const blink::WebFormElement& form_element, FormData* data);
// Helper function to check if there exist any visible form on |frame| which
// equals |form_element|. If |form_element| is null, checks if forms action
// equals |action|. Returns true if so. For forms with empty or unspecified
-// actions, all form data are used for comparison. Form data comparison is
-// disabled on Mac and Android because the update prompt isn't implemented. It
-// may cause many false password updates.
-// TODO(kolos) Turn on all data comparing when the update prompt will be
-// implemented on Mac and Android.
dvadym 2017/03/23 12:37:09 This comment is obsolete, implementation of IsForm
vabr (Chromium) 2017/03/23 20:09:30 Acknowledged.
+// actions, all form data are used for comparison.
bool IsFormVisible(blink::WebFrame* frame,
const blink::WebFormElement& form_element,
const GURL& action,

Powered by Google App Engine
This is Rietveld 408576698