Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2772753002
Cr-Commit-Position: refs/heads/master@{#459708}
Committed: https://chromium.googlesource.com/chromium/src/+/dac4459e32961172505fc30c395886c1236fe469

[Takashi Toyoshima, 2017-03-23 07:40:28]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 07:40:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-23 08:43:58]

Description was changed from

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
==========

to

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
==========

[Takashi Toyoshima, 2017-03-23 08:43:58]

toyoshim@chromium.org changed reviewers:
+ japhet@chromium.org, kinuko@chromium.org

[Takashi Toyoshima, 2017-03-23 08:45:43]

Patch Set 1 -> 2 is mechanical rename. So you could see actual code
modifications in Patch Set 1.

PTAL.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp:50: if (frame
!= m_inspectedFrames->root() ||
This change will cause a behavior change.

https://codereview.chromium.org/2218603003
This was introduced by this change.
It looks we need to check other reload types, but didn't.
I will ask to caseq in a separate CL.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:376: if
(masterDocumentLoader()->loadType() == FrameLoadTypeReloadMainResource)
This will cause a behavior change.

Introduced by https://codereview.chromium.org/1783653002.
Will ask Raj in a separate CL.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp:594: // Child
frame as part of reload
Non-mechanical changes, but want to test the new behavior instead of the legacy
one.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:837: return
FrameLoadTypeReloadMainResource;
non-mechanical. I think reviewers can review this behavior change.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:860:
m_documentLoader->loadType() == FrameLoadTypeReloadMainResource)
non-mechanical. I think reviewers can review this behavior change.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/NavigationScheduler.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/NavigationScheduler.cpp:267:
FrameLoadTypeReloadMainResource, KURL(),
non-mechanical. I think reviewers can review this behavior change.

[Nate Chapin, 2017-03-23 16:56:55]

lgtm

[kinuko, 2017-03-24 00:49:55]

lgtm

[Takashi Toyoshima, 2017-03-24 03:29:17]

Thanks. I'm submitting two other CLs that resolve inspector and data saver
issues respectively. I will submit this patch after rebasing to the master that
have these two CLs.

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp:50: if (frame
!= m_inspectedFrames->root() ||
Resolved: https://codereview.chromium.org/2769153002/

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2772753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:376: if
(masterDocumentLoader()->loadType() == FrameLoadTypeReloadMainResource)
Resolved: https://codereview.chromium.org/2769033004/

[Takashi Toyoshima, 2017-03-24 06:07:32]

toyoshim@chromium.org changed reviewers:
+ haraken@chromium.org

[Takashi Toyoshima, 2017-03-24 06:07:46]

+haraken for modules

[Takashi Toyoshima, 2017-03-24 06:09:09]

Description was changed from

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
==========

to

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
TBR=thakis@chromium.org
==========

[Takashi Toyoshima, 2017-03-24 06:09:34]

TBR=thakis@chromium.org for chrome/ caller side mechanical changes.

[haraken, 2017-03-24 06:09:45]

WebKit LGTM

[Takashi Toyoshima, 2017-03-24 06:13:33]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-24 06:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2772753002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-24 06:13:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-24 06:19:01]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-24 06:19:01]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
haraken@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2772753002/#ps60001
(title: "rebase error fix (replace newly added ReloadMainResource)")

[commit-bot: I haz the power, 2017-03-24 06:19:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 07:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 07:43:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Takashi Toyoshima, 2017-03-27 04:51:12]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-03-27 04:51:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:14:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490590272924960,
"parent_rev": "8a8f67e659f819a459a6076e8fcc634e755dabf6", "commit_rev":
"dac4459e32961172505fc30c395886c1236fe469"}

[commit-bot: I haz the power, 2017-03-27 06:16:28]

Description was changed from

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
TBR=thakis@chromium.org
==========

to

==========
Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG=674404
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2772753002
Cr-Commit-Position: refs/heads/master@{#459708}
Committed:
https://chromium.googlesource.com/chromium/src/+/dac4459e32961172505fc30c3958...
==========

[commit-bot: I haz the power, 2017-03-27 06:16:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/dac4459e32961172505fc30c3958...