Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 2772753002: Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior (Closed)
Patch Set: rebase error fix (replace newly added ReloadMainResource) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015, Google Inc. All rights reserved. 2 * Copyright (c) 2015, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 EXPECT_EQ(WebCachePolicy::ValidatingCacheData, 561 EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
562 fetchContext->resourceRequestCachePolicy( 562 fetchContext->resourceRequestCachePolicy(
563 postRequest, Resource::MainResource, FetchRequest::NoDefer)); 563 postRequest, Resource::MainResource, FetchRequest::NoDefer));
564 564
565 // Re-post 565 // Re-post
566 document->loader()->setLoadType(FrameLoadTypeBackForward); 566 document->loader()->setLoadType(FrameLoadTypeBackForward);
567 EXPECT_EQ(WebCachePolicy::ReturnCacheDataDontLoad, 567 EXPECT_EQ(WebCachePolicy::ReturnCacheDataDontLoad,
568 fetchContext->resourceRequestCachePolicy( 568 fetchContext->resourceRequestCachePolicy(
569 postRequest, Resource::MainResource, FetchRequest::NoDefer)); 569 postRequest, Resource::MainResource, FetchRequest::NoDefer));
570 570
571 // FrameLoadTypeReloadMainResource 571 // FrameLoadTypeReload
572 document->loader()->setLoadType(FrameLoadTypeReloadMainResource); 572 document->loader()->setLoadType(FrameLoadTypeReload);
573 EXPECT_EQ(WebCachePolicy::ValidatingCacheData, 573 EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
574 fetchContext->resourceRequestCachePolicy( 574 fetchContext->resourceRequestCachePolicy(
575 request, Resource::MainResource, FetchRequest::NoDefer)); 575 request, Resource::MainResource, FetchRequest::NoDefer));
576 576
577 // Conditional request 577 // Conditional request
578 document->loader()->setLoadType(FrameLoadTypeStandard); 578 document->loader()->setLoadType(FrameLoadTypeStandard);
579 ResourceRequest conditional("http://www.example.com"); 579 ResourceRequest conditional("http://www.example.com");
580 conditional.setHTTPHeaderField(HTTPNames::If_Modified_Since, "foo"); 580 conditional.setHTTPHeaderField(HTTPNames::If_Modified_Since, "foo");
581 EXPECT_EQ(WebCachePolicy::ValidatingCacheData, 581 EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
582 fetchContext->resourceRequestCachePolicy( 582 fetchContext->resourceRequestCachePolicy(
583 conditional, Resource::MainResource, FetchRequest::NoDefer)); 583 conditional, Resource::MainResource, FetchRequest::NoDefer));
584 584
585 // Set up a child frame 585 // Set up a child frame
586 FrameFetchContext* childFetchContext = createChildFrame(); 586 FrameFetchContext* childFetchContext = createChildFrame();
587 587
588 // Child frame as part of back/forward 588 // Child frame as part of back/forward
589 document->loader()->setLoadType(FrameLoadTypeBackForward); 589 document->loader()->setLoadType(FrameLoadTypeBackForward);
590 EXPECT_EQ(WebCachePolicy::ReturnCacheDataElseLoad, 590 EXPECT_EQ(WebCachePolicy::ReturnCacheDataElseLoad,
591 childFetchContext->resourceRequestCachePolicy( 591 childFetchContext->resourceRequestCachePolicy(
592 request, Resource::MainResource, FetchRequest::NoDefer)); 592 request, Resource::MainResource, FetchRequest::NoDefer));
593 593
594 // Child frame as part of reload 594 // Child frame as part of reload
595 document->loader()->setLoadType(FrameLoadTypeReload); 595 document->loader()->setLoadType(FrameLoadTypeReload);
596 EXPECT_EQ(WebCachePolicy::ValidatingCacheData, 596 EXPECT_EQ(WebCachePolicy::UseProtocolCachePolicy,
597 childFetchContext->resourceRequestCachePolicy( 597 childFetchContext->resourceRequestCachePolicy(
598 request, Resource::MainResource, FetchRequest::NoDefer)); 598 request, Resource::MainResource, FetchRequest::NoDefer));
599 599
600 // Child frame as part of reload bypassing cache 600 // Child frame as part of reload bypassing cache
601 document->loader()->setLoadType(FrameLoadTypeReloadBypassingCache); 601 document->loader()->setLoadType(FrameLoadTypeReloadBypassingCache);
602 EXPECT_EQ(WebCachePolicy::BypassingCache, 602 EXPECT_EQ(WebCachePolicy::BypassingCache,
603 childFetchContext->resourceRequestCachePolicy( 603 childFetchContext->resourceRequestCachePolicy(
604 request, Resource::MainResource, FetchRequest::NoDefer)); 604 request, Resource::MainResource, FetchRequest::NoDefer));
605 } 605 }
606 606
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 719
720 // Tests if reload variants can reflect the current data saver setting. 720 // Tests if reload variants can reflect the current data saver setting.
721 TEST_F(FrameFetchContextTest, ChangeDataSaverConfig) { 721 TEST_F(FrameFetchContextTest, ChangeDataSaverConfig) {
722 Settings* settings = document->frame()->settings(); 722 Settings* settings = document->frame()->settings();
723 settings->setDataSaverEnabled(true); 723 settings->setDataSaverEnabled(true);
724 ResourceRequest resourceRequest("http://www.example.com"); 724 ResourceRequest resourceRequest("http://www.example.com");
725 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource); 725 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
726 EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data")); 726 EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
727 727
728 settings->setDataSaverEnabled(false); 728 settings->setDataSaverEnabled(false);
729 document->loader()->setLoadType(FrameLoadTypeReloadMainResource); 729 document->loader()->setLoadType(FrameLoadTypeReload);
730 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource); 730 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
731 EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data")); 731 EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data"));
732 732
733 settings->setDataSaverEnabled(true); 733 settings->setDataSaverEnabled(true);
734 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource); 734 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
735 EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data")); 735 EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
736 736
737 settings->setDataSaverEnabled(false); 737 settings->setDataSaverEnabled(false);
738 document->loader()->setLoadType(FrameLoadTypeReloadMainResource); 738 document->loader()->setLoadType(FrameLoadTypeReload);
739 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource); 739 fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
740 EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data")); 740 EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data"));
741 } 741 }
742 742
743 // Tests that the embedder gets correct notification when a resource is loaded 743 // Tests that the embedder gets correct notification when a resource is loaded
744 // from the memory cache. 744 // from the memory cache.
745 TEST_F(FrameFetchContextMockedLocalFrameClientTest, 745 TEST_F(FrameFetchContextMockedLocalFrameClientTest,
746 DispatchDidLoadResourceFromMemoryCache) { 746 DispatchDidLoadResourceFromMemoryCache) {
747 ResourceRequest resourceRequest(url); 747 ResourceRequest resourceRequest(url);
748 Resource* resource = MockResource::create(resourceRequest); 748 Resource* resource = MockResource::create(resourceRequest);
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 setFilterPolicy(WebDocumentSubresourceFilter::WouldDisallow); 931 setFilterPolicy(WebDocumentSubresourceFilter::WouldDisallow);
932 932
933 EXPECT_EQ(ResourceRequestBlockedReason::None, canRequest()); 933 EXPECT_EQ(ResourceRequestBlockedReason::None, canRequest());
934 EXPECT_EQ(0, getFilteredLoadCallCount()); 934 EXPECT_EQ(0, getFilteredLoadCallCount());
935 935
936 EXPECT_EQ(ResourceRequestBlockedReason::None, canRequestPreload()); 936 EXPECT_EQ(ResourceRequestBlockedReason::None, canRequestPreload());
937 EXPECT_EQ(0, getFilteredLoadCallCount()); 937 EXPECT_EQ(0, getFilteredLoadCallCount());
938 } 938 }
939 939
940 } // namespace blink 940 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698