Remove IDC_CREATE_SHORTCUT and its associated UI.

Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView is now used instead
of CreateUrlApplicationShortcutView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
Review-Url: https://codereview.chromium.org/2772713002
Cr-Commit-Position: refs/heads/master@{#462322}
Committed: https://chromium.googlesource.com/chromium/src/+/b72edff87d31139a6c466b14c153776029bd6008

[tapted, 2017-03-23 05:42:10]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 05:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 05:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 05:44:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tapted, 2017-03-23 20:58:48]

Description was changed from

==========
Remove IDC_CREATE_SHORTCUT


cl format


Flatten


cl format


purge

BUG=702551
==========

to

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}".

BUG=702551
==========

[tapted, 2017-03-23 20:58:48]

tapted@chromium.org changed reviewers:
+ dominickn@chromium.org

[tapted, 2017-03-23 21:00:20]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 21:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 21:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 21:18:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2017-03-31 03:16:34]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 03:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-03-31 03:55:03]

Patchset #1 (id:1) has been deleted

[tapted, 2017-03-31 03:55:11]

Patchset #1 (id:20001) has been deleted

[tapted, 2017-03-31 03:55:21]

Patchset #1 (id:40001) has been deleted

[tapted, 2017-03-31 04:07:08]

Description was changed from

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}".

BUG=702551
==========

to

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}".

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

[commit-bot: I haz the power, 2017-03-31 04:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 04:54:03]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tapted, 2017-03-31 05:23:22]

Hiya dom, please take a look.

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/global_menu_bar_x11.cc (left):

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/global_menu_bar_x11.cc:155: {
IDS_CREATE_SHORTCUTS, IDC_CREATE_SHORTCUTS },
i dunno if a string like "Add To Desktop" belongs in Chrome's File menu....
feels too much like it would be adding Chrome to the desktop, not the web page.

[dominickn, 2017-04-03 03:10:01]

Looks fine to me, but I'm a non-expert for a bunch of these files. :)

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/create_application_shortcut_view.h (right):

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:10: #include
"base/macros.h"
#include "base/callback.h"

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:11: #include
"base/strings/string16.h"
#include "base/memory/weak_ptr.h"

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/global_menu_bar_x11.cc (left):

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/global_menu_bar_x11.cc:155: {
IDS_CREATE_SHORTCUTS, IDC_CREATE_SHORTCUTS },
On 2017/03/31 05:23:21, tapted wrote:
> i dunno if a string like "Add To Desktop" belongs in Chrome's File menu....
> feels too much like it would be adding Chrome to the desktop, not the web
page.

Yeah, it seems weird to me for it to be in the File menu. Not really sure where
else in that bar it would go though.

[tapted, 2017-04-04 01:19:26]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 01:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-04 01:21:21]

Description was changed from

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}".

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

to

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

[tapted, 2017-04-04 01:25:47]

Description was changed from

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

to

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView is now used instead
of CreateUrlApplicationShortcutView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

[tapted, 2017-04-04 01:25:48]

tapted@chromium.org changed reviewers:
+ erg@chromium.org, pkasting@chromium.org

[tapted, 2017-04-04 01:30:39]

tapted@chromium.org changed reviewers:
+ isherman@chromium.org

[tapted, 2017-04-04 01:30:40]

+pkasting for chrome/browser/ui
+erg for shell_integration_linux.cc and global_menu_bar_x11.cc
+isherman for histograms.xml

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/create_application_shortcut_view.h (right):

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:10: #include
"base/macros.h"
On 2017/04/03 03:10:00, dominickn wrote:
> #include "base/callback.h"

Done.

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:11: #include
"base/strings/string16.h"
On 2017/04/03 03:10:00, dominickn wrote:
> #include "base/memory/weak_ptr.h"

Done.

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/global_menu_bar_x11.cc (left):

https://codereview.chromium.org/2772713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/global_menu_bar_x11.cc:155: {
IDS_CREATE_SHORTCUTS, IDC_CREATE_SHORTCUTS },
On 2017/04/03 03:10:00, dominickn wrote:
> On 2017/03/31 05:23:21, tapted wrote:
> > i dunno if a string like "Add To Desktop" belongs in Chrome's File menu....
> > feels too much like it would be adding Chrome to the desktop, not the web
> page.
> 
> Yeah, it seems weird to me for it to be in the File menu. Not really sure
where
> else in that bar it would go though.

Acknowledged. Maybe erg@ has an opinion on this (e.g. is there a strict rule
that things in the chrome app_menu should appear in the x11 menu as well?)

[Peter Kasting, 2017-04-04 02:31:49]

LGTM

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/app_menu_model.h (left):

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/app_menu_model.h:50: MENU_ACTION_CREATE_SHORTCUTS =
21,
Nit: Might be nice to have all the holes in this table filled and list removed
ones like:

  // REMOVED: MENU_ACTION_CREATE_SHORTCUTS = 21,

But maybe not worth it

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/create_application_shortcut_view.h (right):

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:29: // Create an
application shortcut pointing to a chrome application.
Nit: Maybe "A dialog allowing the user to create a desktop shortcut pointing to
a chrome app."

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:42: // Overridden
from views::View:
Nit: Combine these two lists as the DialogDelegateView overrides (class does not
inherit directly from either View or DialogDelegate)

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:60: // Overridden
from views::ButtonListener:
Nit: Leave in public section since base class declaration is public

[commit-bot: I haz the power, 2017-04-04 03:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 03:08:58]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-04-04 05:07:05]

histograms.xml lgtm

[tapted, 2017-04-04 06:34:35]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 06:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-04 06:48:39]

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/app_menu_model.h (left):

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/app_menu_model.h:50: MENU_ACTION_CREATE_SHORTCUTS =
21,
On 2017/04/04 02:31:49, Peter Kasting wrote:
> Nit: Might be nice to have all the holes in this table filled and list removed
> ones like:
> 
>   // REMOVED: MENU_ACTION_CREATE_SHORTCUTS = 21,
> 
> But maybe not worth it

10,11,12 set a precedent for holes (restart in metro mode stuff). Leaving this,
but I don't feel strongly about it (I can do some digging to find out what the
original enum identifiers were, but a negative diff delta feels more satisfying
:)

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/create_application_shortcut_view.h (right):

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:29: // Create an
application shortcut pointing to a chrome application.
On 2017/04/04 02:31:49, Peter Kasting wrote:
> Nit: Maybe "A dialog allowing the user to create a desktop shortcut pointing
to
> a chrome app."

Done.

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:42: // Overridden
from views::View:
On 2017/04/04 02:31:49, Peter Kasting wrote:
> Nit: Combine these two lists as the DialogDelegateView overrides (class does
not
> inherit directly from either View or DialogDelegate)

Done.

https://codereview.chromium.org/2772713002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/create_application_shortcut_view.h:60: // Overridden
from views::ButtonListener:
On 2017/04/04 02:31:49, Peter Kasting wrote:
> Nit: Leave in public section since base class declaration is public

Done.

[commit-bot: I haz the power, 2017-04-04 08:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 08:20:33]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-04 17:06:42]

lgtm

[tapted, 2017-04-04 23:32:40]

tapted@chromium.org changed reviewers:
+ benwells@chromium.org, grt@chromium.org

[tapted, 2017-04-04 23:32:40]

+grt, +benwells  for last OWNERS bits

grt: chrome/app/chrome_command_ids.h
benwells: chrome/browser/extensions/tab_helper*

- Thanks!

[benwells, 2017-04-05 00:45:55]

lgtm

[grt (UTC plus 2), 2017-04-05 08:28:00]

lgtm w/ nits

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1298:
base::RecordAction(UserMetricsAction("CreateShortcut"));
mark as obsolete in actions.xml

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/app_menu_model.cc (left):

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/app_menu_model.cc:201:
AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);
please remove IDS_CREATE_SHORTCUTS from chrome/app/generated_resources.grd

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/app_menu_model.cc:442:
UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts",
mark this suffix as obsolete in histograms.xml

[tapted, 2017-04-05 12:10:34]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 12:10:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-05 12:35:44]

isherman: PTAL for actions.xml (e.g. should I remove the placeholder strings for
the obsolete item?)

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1298:
base::RecordAction(UserMetricsAction("CreateShortcut"));
On 2017/04/05 08:28:00, grt (UTC plus 2) wrote:
> mark as obsolete in actions.xml

Done. (didn't know about actions.xml...)

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/app_menu_model.cc (left):

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/app_menu_model.cc:201:
AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);
On 2017/04/05 08:28:00, grt (UTC plus 2) wrote:
> please remove IDS_CREATE_SHORTCUTS from chrome/app/generated_resources.grd

Done.

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/app_menu_model.cc:442:
UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts",
On 2017/04/05 08:28:00, grt (UTC plus 2) wrote:
> mark this suffix as obsolete in histograms.xml

I think I got this one already :). (just.. histograms.xml is too big to get the
context 40 lines below that has 
  <affected-histogram name="WrenchMenu.TimeToAction"/>

https://codereview.chromium.org/2772713002/diff/140001/tools/metrics/actions/...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2772713002/diff/140001/tools/metrics/actions/...
tools/metrics/actions/actions.xml:9798: <action
name="MobileMenuDataSaverOpened">
I get a presubmit failure:

** Presubmit ERRORS **
actions.xml is not up to date or is not formatted correctly; run
extract_actions.py to fix

and these lines got added. It doesn't belong in this CL - I've made
https://codereview.chromium.org/2801693002/ and will rebase when that lands.

[commit-bot: I haz the power, 2017-04-05 13:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:02:26]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-04-05 13:32:05]

Thanks.

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/app_menu_model.cc (left):

https://codereview.chromium.org/2772713002/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/app_menu_model.cc:442:
UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts",
On 2017/04/05 12:35:43, tapted wrote:
> On 2017/04/05 08:28:00, grt (UTC plus 2) wrote:
> > mark this suffix as obsolete in histograms.xml
> 
> I think I got this one already :). (just.. histograms.xml is too big to get
the
> context 40 lines below that has 
>   <affected-histogram name="WrenchMenu.TimeToAction"/>

Indeed! Apologies for the false alarm.

[Ilya Sherman, 2017-04-05 23:06:25]

actions.xml lgtm

[tapted, 2017-04-06 00:26:39]

Thanks all!

https://codereview.chromium.org/2772713002/diff/140001/tools/metrics/actions/...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2772713002/diff/140001/tools/metrics/actions/...
tools/metrics/actions/actions.xml:9798: <action
name="MobileMenuDataSaverOpened">
On 2017/04/05 12:35:44, tapted wrote:
> I get a presubmit failure:
> 
> ** Presubmit ERRORS **
> actions.xml is not up to date or is not formatted correctly; run
> extract_actions.py to fix
> 
> and these lines got added. It doesn't belong in this CL - I've made
> https://codereview.chromium.org/2801693002/ and will rebase when that lands.

(This has now been resolved by r462081)

[tapted, 2017-04-06 00:27:17]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-04-06 00:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, benwells@chromium.org, erg@chromium.org,
grt@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2772713002/#ps160001
(title: "rebase to get r462081")

[commit-bot: I haz the power, 2017-04-06 00:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:59:27]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1491438437423300,
"parent_rev": "430d8884a1783783c709bd01e544f682f5134915", "commit_rev":
"b72edff87d31139a6c466b14c153776029bd6008"}

[commit-bot: I haz the power, 2017-04-06 02:00:12]

Description was changed from

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView is now used instead
of CreateUrlApplicationShortcutView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551
==========

to

==========
Remove IDC_CREATE_SHORTCUT and its associated UI.

IDC_CREATE_SHORTCUT allows a user to create a hosted app from an
arbitrary web page. It was never implemented for Mac. On other
platforms, it has beed replaced by "Add to {Desktop, Homescreen,
Applications}". That is, BookmarkAppConfirmationView is now used instead
of CreateUrlApplicationShortcutView.

And although it may appear that IDC_CREATE_SHORTCUTS is an "enabled"
command, there's actually no way to invoke that command on any platform
because app_menu_model.cc will always add IDC_CREATE_HOSTED_APP instead.
(One exception: the x11 menubar on Desktop Linux had an entry, but
that's accidental).

BUG=702551

Review-Url: https://codereview.chromium.org/2772713002
Cr-Commit-Position: refs/heads/master@{#462322}
Committed:
https://chromium.googlesource.com/chromium/src/+/b72edff87d31139a6c466b14c153...
==========

[commit-bot: I haz the power, 2017-04-06 02:00:13]

Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/b72edff87d31139a6c466b14c153...