Remove IDC_CREATE_SHORTCUT and its associated UI.

chrome/browser/ui/toolbar/app_menu_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/app_menu_model.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/command_line.h"
@@ skipping 158 matching lines @@
 }
 
 ToolsMenuModel::~ToolsMenuModel() {}
 
 // More tools submenu is constructed as follows:
 // - Page specific actions overflow (save page, adding to desktop).
 // - Browser / OS level tools (extensions, task manager).
 // - Developer tools.
 // - Option to enable profiling.
 void ToolsMenuModel::Build(Browser* browser) {
-  bool show_create_shortcuts = true;
-#if defined(OS_CHROMEOS) || defined(OS_MACOSX) || defined(USE_ASH)
-  show_create_shortcuts = false;
-#endif
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableSaveAsMenuLabelExperiment) ||
       base::FieldTrialList::FindFullName("SaveAsMenuText") == "download") {
     AddItemWithStringId(IDC_SAVE_PAGE, IDS_DOWNLOAD_PAGE);
   } else {
     AddItemWithStringId(IDC_SAVE_PAGE, IDS_SAVE_PAGE);
   }
 
   if (extensions::util::IsNewBookmarkAppsEnabled()) {
     int string_id = IDS_ADD_TO_DESKTOP;
 #if defined(OS_MACOSX)
     string_id = IDS_ADD_TO_APPLICATIONS;
 #endif
 #if defined(USE_ASH)
     string_id = IDS_ADD_TO_SHELF;
 #endif  // defined(USE_ASH)
     AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id);
-  } else if (show_create_shortcuts) {
-    AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);

[grt (UTC plus 2), 2017/04/05 08:28:00]

please remove IDS_CREATE_SHORTCUTS from chrome/app/generated_resources.grd

[tapted, 2017/04/05 12:35:44]

Done.

   }
 
   AddSeparator(ui::NORMAL_SEPARATOR);
   AddItemWithStringId(IDC_CLEAR_BROWSING_DATA, IDS_CLEAR_BROWSING_DATA);
   AddItemWithStringId(IDC_MANAGE_EXTENSIONS, IDS_SHOW_EXTENSIONS);
   if (chrome::CanOpenTaskManager())
     AddItemWithStringId(IDC_TASK_MANAGER, IDS_TASK_MANAGER);
 #if defined(OS_CHROMEOS)
   AddItemWithStringId(IDC_TAKE_SCREENSHOT, IDS_TAKE_SCREENSHOT);
 #endif
@@ skipping 218 matching lines @@
       break;
 
     // Tools menu.
     case IDC_CREATE_HOSTED_APP:
       if (!uma_action_recorded_) {
         UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateHostedApp",
                                    delta);
       }
       LogMenuAction(MENU_ACTION_CREATE_HOSTED_APP);
       break;
-    case IDC_CREATE_SHORTCUTS:
-      if (!uma_action_recorded_)
-        UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts",

[grt (UTC plus 2), 2017/04/05 08:28:00]

mark this suffix as obsolete in histograms.xml

[tapted, 2017/04/05 12:35:43]

I think I got this one already :). (just.. histograms.xml is too big to get the
context 40 lines below that has 
  <affected-histogram name="WrenchMenu.TimeToAction"/>

[grt (UTC plus 2), 2017/04/05 13:32:05]

Indeed! Apologies for the false alarm.

-                                   delta);
-      LogMenuAction(MENU_ACTION_CREATE_SHORTCUTS);
-      break;
     case IDC_MANAGE_EXTENSIONS:
       if (!uma_action_recorded_) {
         UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.ManageExtensions",
                                    delta);
       }
       LogMenuAction(MENU_ACTION_MANAGE_EXTENSIONS);
       break;
     case IDC_TASK_MANAGER:
       if (!uma_action_recorded_) {
         UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.TaskManager",
@@ skipping 406 matching lines @@
                        browser_->tab_strip_model()->GetActiveWebContents())
                        ->GetZoomPercent();
   }
   zoom_label_ = base::FormatPercent(zoom_percent);
 }
 
 void AppMenuModel::OnZoomLevelChanged(
     const content::HostZoomMap::ZoomLevelChange& change) {
   UpdateZoomControls();
 }