chromeos: Improve ProxyResolutionServiceProvider testing.

chromeos: Improve ProxyResolutionServiceProvider testing.

Add additional tests to exercise asynchronous proxy
resolution and error handling.

BUG=446115, 703217
Review-Url: https://codereview.chromium.org/2772573002
Cr-Commit-Position: refs/heads/master@{#458948}
Committed: https://chromium.googlesource.com/chromium/src/+/87a5e86e242ee80ec08e268bcfa6741e87adedaa

[Daniel Erat, 2017-03-22 22:58:55]

derat@chromium.org changed reviewers:
+ jamescook@chromium.org, satorux@chromium.org, teravest@chromium.org

[Daniel Erat, 2017-03-22 22:58:56]

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
File chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc (right):

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc:30: return
proxy_service->ResolveProxy(url, std::string(), results, callback,
i don't love adding tiny shims like this that just call a method on an object
passed to them, but net::ProxyService seems pretty un-stubbable. :-(

[Daniel Erat, 2017-03-22 22:59:05]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-22 23:16:27]

LGTM with a couple suggestions

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
File chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc (right):

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc:27:
net::ProxyInfo* results,
DCHECK this?

https://codereview.chromium.org/2772573002/diff/1/chromeos/dbus/services/prox...
File chromeos/dbus/services/proxy_resolution_service_provider.h (right):

https://codereview.chromium.org/2772573002/diff/1/chromeos/dbus/services/prox...
chromeos/dbus/services/proxy_resolution_service_provider.h:148: const
net::CompletionCallback& callback) = 0;
Could this provide a default implementation so it doesn't have to ping-pong into
chrome?

[Daniel Erat, 2017-03-22 23:23:40]

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
File chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc (right):

https://codereview.chromium.org/2772573002/diff/1/chrome/browser/chromeos/dbu...
chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc:27:
net::ProxyInfo* results,
On 2017/03/22 23:16:27, James Cook wrote:
> DCHECK this?

i wasn't sure if that was keeping in the spirit of this being a shim, but sure.
:-)

https://codereview.chromium.org/2772573002/diff/1/chromeos/dbus/services/prox...
File chromeos/dbus/services/proxy_resolution_service_provider.h (right):

https://codereview.chromium.org/2772573002/diff/1/chromeos/dbus/services/prox...
chromeos/dbus/services/proxy_resolution_service_provider.h:148: const
net::CompletionCallback& callback) = 0;
On 2017/03/22 23:16:27, James Cook wrote:
> Could this provide a default implementation so it doesn't have to ping-pong
into
> chrome?

hmm. this interface needs to be implemented by chrome regardless (for
GetRequestContext), so i'm not sure that doing this would buy us much. providing
a default implementation of a method instead of keeping this as an abstract
interface feels like it makes the code harder to understand, though.

[Daniel Erat, 2017-03-22 23:24:24]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:07:25]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2017-03-23 00:09:29]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2017-03-23 00:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2772573002/#ps20001
(title: "add a DCHECK")

[commit-bot: I haz the power, 2017-03-23 00:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:20:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490227769686090,
"parent_rev": "56a126689a4bdbfa0678f94c4eb9539d1d5930de", "commit_rev":
"87a5e86e242ee80ec08e268bcfa6741e87adedaa"}

[commit-bot: I haz the power, 2017-03-23 00:20:59]

Description was changed from

==========
chromeos: Improve ProxyResolutionServiceProvider testing.

Add additional tests to exercise asynchronous proxy
resolution and error handling.

BUG=446115,703217
==========

to

==========
chromeos: Improve ProxyResolutionServiceProvider testing.

Add additional tests to exercise asynchronous proxy
resolution and error handling.

BUG=446115,703217

Review-Url: https://codereview.chromium.org/2772573002
Cr-Commit-Position: refs/heads/master@{#458948}
Committed:
https://chromium.googlesource.com/chromium/src/+/87a5e86e242ee80ec08e268bcfa6...
==========

[commit-bot: I haz the power, 2017-03-23 00:21:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87a5e86e242ee80ec08e268bcfa6...