chromeos: Improve ProxyResolutionServiceProvider testing.

chromeos/dbus/services/proxy_resolution_service_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SERVICES_PROXY_RESOLUTION_SERVICE_PROVIDER_H_
 #define CHROMEOS_DBUS_SERVICES_PROXY_RESOLUTION_SERVICE_PROVIDER_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "chromeos/chromeos_export.h"
 #include "chromeos/dbus/services/cros_dbus_service.h"
 #include "dbus/exported_object.h"
+#include "net/base/completion_callback.h"
+
+class GURL;
 
 namespace base {
 class SingleThreadTaskRunner;
 }
 
 namespace dbus {
 class MethodCall;
 }
 
 namespace net {
+class ProxyInfo;
+class ProxyService;
 class URLRequestContextGetter;
 }
 
 namespace chromeos {
 
 class ProxyResolverDelegate;
 class ProxyResolverInterface;
 
 // This class provides proxy resolution service for CrosDBusService.
 // It processes proxy resolution requests for ChromeOS clients.
@@ skipping 90 matching lines @@
 };
 
 // The delegate which provides necessary objects to the proxy resolver.
 class CHROMEOS_EXPORT ProxyResolverDelegate {
  public:
   virtual ~ProxyResolverDelegate() {}
 
   // Returns the request context used to perform proxy resolution.
   // Always called on UI thread.
   virtual scoped_refptr<net::URLRequestContextGetter> GetRequestContext() = 0;
+
+  // Thin wrapper around net::ProxyService::ResolveProxy() to make testing
+  // easier.
+  virtual int ResolveProxy(net::ProxyService* proxy_service,
+                           const GURL& url,
+                           net::ProxyInfo* results,
+                           const net::CompletionCallback& callback) = 0;
 };
 
 // The interface is defined so we can mock out the proxy resolver
 // implementation.
 class CHROMEOS_EXPORT ProxyResolverInterface {
  public:
   // Resolves the proxy for the given URL. Returns the result as a
   // signal sent to |signal_interface| and
   // |signal_name|. |exported_object| will be used to send the
   // signal. The signal contains the three string members:
   //
   // - source url: the requested source URL.
   // - proxy info: proxy info for the source URL in PAC format.
   // - error message: empty if the proxy resolution was successful.
   virtual void ResolveProxy(
       const std::string& source_url,
       const std::string& signal_interface,
       const std::string& signal_name,
       scoped_refptr<dbus::ExportedObject> exported_object) = 0;
 
   virtual ~ProxyResolverInterface();
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SERVICES_PROXY_RESOLUTION_SERVICE_PROVIDER_H_