chromeos: Improve ProxyResolutionServiceProvider testing.

chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.h"
 
 #include "chrome/browser/profiles/profile_manager.h"
+#include "net/log/net_log_with_source.h"
+#include "net/proxy/proxy_service.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace chromeos {
 
 ChromeProxyResolverDelegate::ChromeProxyResolverDelegate() {}
 
 ChromeProxyResolverDelegate::~ChromeProxyResolverDelegate() {}
 
 scoped_refptr<net::URLRequestContextGetter>
 ChromeProxyResolverDelegate::GetRequestContext() {
   Profile* profile = ProfileManager::GetPrimaryUserProfile();
   return profile->GetRequestContext();
 }
 
+int ChromeProxyResolverDelegate::ResolveProxy(
+    net::ProxyService* proxy_service,
+    const GURL& url,
+    net::ProxyInfo* results,

[James Cook, 2017/03/22 23:16:27]

DCHECK this?

[Daniel Erat, 2017/03/22 23:23:40]

i wasn't sure if that was keeping in the spirit of this being a shim, but sure.
:-)

+    const net::CompletionCallback& callback) {
+  DCHECK(proxy_service);
+  return proxy_service->ResolveProxy(url, std::string(), results, callback,

[Daniel Erat, 2017/03/22 22:58:56]

i don't love adding tiny shims like this that just call a method on an object
passed to them, but net::ProxyService seems pretty un-stubbable. :-(

+                                     nullptr, nullptr, net::NetLogWithSource());
+}
+
 }  // namespace chromeos