Make Clipboard.java a singleton pattern.

Make Clipboard.java a singleton pattern.

BUG=

Review-Url: https://codereview.chromium.org/2772073002
Cr-Commit-Position: refs/heads/master@{#460176}
Committed: https://chromium.googlesource.com/chromium/src/+/34662d716488c15221573880f3462b1a3e2c123c

[Mark P, 2017-03-24 21:51:18]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2017-03-24 21:51:19]

https://codereview.chromium.org/2772073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
(right):

https://codereview.chromium.org/2772073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java:188:
Clipboard.getInstance().setText(mSelectionDelegate.getSelectedItems().get(0).getUrl());
Is the mActivity here always equivalent to the
ContextUtils.getApplicationContext()?

[Ted C, 2017-03-24 22:53:34]

https://codereview.chromium.org/2772073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
(right):

https://codereview.chromium.org/2772073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java:188:
Clipboard.getInstance().setText(mSelectionDelegate.getSelectedItems().get(0).getUrl());
On 2017/03/24 21:51:19, Mark P wrote:
> Is the mActivity here always equivalent to the
> ContextUtils.getApplicationContext()?

No.  The application is a higher level concept that can be shared across all
activities in the same process.

But, I don't think we need the activity (in other cases we use the application
including from native), so I'm pretty confident that we can use just the
application.

[Mark P, 2017-03-24 23:57:59]

lgtm

[Ted C, 2017-03-28 17:06:16]

tedchoc@chromium.org changed reviewers:
+ dcheng@chromium.org

[Ted C, 2017-03-28 17:06:17]

+dcheng for ui/base/clipboard/clipboard_android.cc OWNERS

[dcheng, 2017-03-28 17:33:41]

The C++ looks fine, but one question about the Java changes.

https://codereview.chromium.org/2772073002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right):

https://codereview.chromium.org/2772073002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/Clipboard.java:39: return new
Clipboard();
How come this isn't returning sInstance?

[Ted C, 2017-03-28 17:43:49]

Fixed...you might have heard the groan I made from here when I saw that

https://codereview.chromium.org/2772073002/diff/20001/ui/android/java/src/org...
File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right):

https://codereview.chromium.org/2772073002/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/base/Clipboard.java:39: return new
Clipboard();
On 2017/03/28 17:33:40, dcheng wrote:
> How come this isn't returning sInstance?

<facepalm>sigh</facepalm>

[dcheng, 2017-03-28 17:45:34]

LGTM

=)

[Mark P, 2017-03-28 17:47:51]

I had an equally large groan, as I was the one who was supposed to have
reviewed this code...  *sigh*

Still, I'd be impressed if Ted's groan traveled across state lines. :-)

--mark

On Tue, Mar 28, 2017 at 10:45 AM, <dcheng@chromium.org> wrote:

> LGTM
>
> =)
>
> https://codereview.chromium.org/2772073002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ted C, 2017-03-28 17:49:37]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-03-28 17:49:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2772073002/#ps40001
(title: "Fix shame")

[commit-bot: I haz the power, 2017-03-28 17:50:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:43:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490723377381180,
"parent_rev": "c9e657daecd6071ed7f89a2a73f6e187a9cb480f", "commit_rev":
"34662d716488c15221573880f3462b1a3e2c123c"}

[commit-bot: I haz the power, 2017-03-28 18:44:07]

Description was changed from

==========
Make Clipboard.java a singleton pattern.

BUG=
==========

to

==========
Make Clipboard.java a singleton pattern.

BUG=

Review-Url: https://codereview.chromium.org/2772073002
Cr-Commit-Position: refs/heads/master@{#460176}
Committed:
https://chromium.googlesource.com/chromium/src/+/34662d716488c15221573880f346...
==========

[commit-bot: I haz the power, 2017-03-28 18:44:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/34662d716488c15221573880f346...