chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java - Issue 2772073002: Make Clipboard.java a singleton pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

Issue 2772073002: Make Clipboard.java a singleton pattern. (Closed)

Patch Set: Fix shame Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java ('k') | ui/android/java/src/org/chromium/ui/base/Clipboard.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

index a788ba7834b7edfae3dd33ecfe1e7a7c5b7bdb40..f0353b5bc5c055931e269ea89a60e0183d1bf957 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

@@ -40,7 +40,6 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {

public static final String PAGESPEED_PASSTHROUGH_HEADERS =

"Chrome-Proxy: pass-through\nCache-Control: no-cache";

- private final Clipboard mClipboard;

private final Tab mTab;

private boolean mLoadOriginalImageRequestedForPageLoad;

private EmptyTabObserver mDataReductionProxyContextMenuTabObserver;

@@ -50,7 +49,6 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {

public TabContextMenuItemDelegate(Tab tab) {

mTab = tab;

- mClipboard = new Clipboard(mTab.getApplicationContext());

mDataReductionProxyContextMenuTabObserver = new EmptyTabObserver() {

@Override

public void onPageLoadStarted(Tab tab, String url) {

@@ -92,7 +90,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {

@Override

public void onSaveToClipboard(String text, int clipboardType) {

- mClipboard.setText(text);

+ Clipboard.getInstance().setText(text);

}

@Override