Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

Issue 2772073002: Make Clipboard.java a singleton pattern. (Closed)
Patch Set: Fix shame Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
index a788ba7834b7edfae3dd33ecfe1e7a7c5b7bdb40..f0353b5bc5c055931e269ea89a60e0183d1bf957 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
@@ -40,7 +40,6 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
public static final String PAGESPEED_PASSTHROUGH_HEADERS =
"Chrome-Proxy: pass-through\nCache-Control: no-cache";
- private final Clipboard mClipboard;
private final Tab mTab;
private boolean mLoadOriginalImageRequestedForPageLoad;
private EmptyTabObserver mDataReductionProxyContextMenuTabObserver;
@@ -50,7 +49,6 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
*/
public TabContextMenuItemDelegate(Tab tab) {
mTab = tab;
- mClipboard = new Clipboard(mTab.getApplicationContext());
mDataReductionProxyContextMenuTabObserver = new EmptyTabObserver() {
@Override
public void onPageLoadStarted(Tab tab, String url) {
@@ -92,7 +90,7 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {
@Override
public void onSaveToClipboard(String text, int clipboardType) {
- mClipboard.setText(text);
+ Clipboard.getInstance().setText(text);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698