Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java

Issue 2772073002: Make Clipboard.java a singleton pattern. (Closed)
Patch Set: Fix shame Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
index 61bf103fa4306957174c29a087f5c4142095c6f5..ff156126c6f53e34afd624a8fa44b992d2735bf9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
@@ -182,8 +182,7 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
return true;
} else if (item.getItemId() == R.id.selection_mode_copy_link) {
recordUserActionWithOptionalSearch("CopyLink");
- Clipboard clipboard = new Clipboard(mActivity);
- clipboard.setText(mSelectionDelegate.getSelectedItems().get(0).getUrl());
+ Clipboard.getInstance().setText(mSelectionDelegate.getSelectedItems().get(0).getUrl());
mSelectionDelegate.clearSelection();
Snackbar snackbar = Snackbar.make(mActivity.getString(R.string.copied), this,
Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_HISTORY_LINK_COPIED);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698