Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2771913002: WebVR: move animation state check to deferred task (Closed)

Created:
3 years, 9 months ago by klausw
Modified:
3 years, 9 months ago
Reviewers:
bajones, bshe
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

WebVR: move animation state check to deferred task The animation controller or document may have disappeared in between scheduling the callback and executing it. BUG=701444 R=bajones, mthiesse NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2752343002 Cr-Commit-Position: refs/heads/master@{#457618} (cherry picked from commit efd3d31152e48d1089175b9256c56bccbe6d9792) Review-Url: https://codereview.chromium.org/2771913002 Cr-Commit-Position: refs/branch-heads/3029@{#395} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1598a6bafc5d202e1fe34a2976ea12c37e80214b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
klausw
For merge to branch-heads/3029 as discussed.
3 years, 9 months ago (2017-03-23 20:22:56 UTC) #2
klausw
bajones@chromium.org: Second part of cherry-pick, original was https://codereview.chromium.org/2752343002
3 years, 9 months ago (2017-03-23 20:26:10 UTC) #4
bshe
On 2017/03/23 20:26:10, klausw wrote: > mailto:bajones@chromium.org: Second part of cherry-pick, original was > https://codereview.chromium.org/2752343002 ...
3 years, 9 months ago (2017-03-23 20:34:00 UTC) #5
bajones
lgtm
3 years, 9 months ago (2017-03-23 20:40:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771913002/1
3 years, 9 months ago (2017-03-23 20:58:01 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:02:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1598a6bafc5d202e1fe34a2976ea...

Powered by Google App Engine
This is Rietveld 408576698