WebVR: process animations from posted task to yield for other events

WebVR: process animations from posted task to yield for other events

If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.

BUG=701444
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)

Review-Url: https://codereview.chromium.org/2774673003
Cr-Commit-Position: refs/branch-heads/3029@{#394}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/40b2aa9268c6ff790dd6691bac26b5e15799852e

[klausw, 2017-03-23 20:22:18]

klausw@chromium.org changed reviewers:
+ bshe@chromium.org

[klausw, 2017-03-23 20:22:19]

Merged to branch-heads/3029 as discussed

[klausw, 2017-03-23 20:23:41]

On 2017/03/23 20:22:19, klausw wrote:
> Merged to branch-heads/3029 as discussed

I meant this is cherry-picked onto branch-heads/3029 for merging as discussed.

[klausw, 2017-03-23 20:24:55]

klausw@chromium.org changed reviewers:
+ bajones@chromium.org

[klausw, 2017-03-23 20:24:56]

bajones@chromium.org: This is a cherry-pick, can you confirm the changes to
VRDisplay.* match those in https://codereview.chromium.org/2748293002 ?

[bshe, 2017-03-23 20:31:48]

On 2017/03/23 20:24:56, klausw wrote:
> mailto:bajones@chromium.org: This is a cherry-pick, can you confirm the
changes to
> VRDisplay.* match those in https://codereview.chromium.org/2748293002 ?

lgtm

[klausw, 2017-03-23 20:33:44]

The CQ bit was checked by klausw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 20:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:34:12]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[klausw, 2017-03-23 20:35:02]

Description was changed from

==========
WebVR: process animations from posted task to yield for other events

If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.

BUG=701444

Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)
==========

to

==========
WebVR: process animations from posted task to yield for other events

If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.

BUG=701444
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)
==========

[bajones, 2017-03-23 20:39:22]

On 2017/03/23 20:31:48, bshe wrote:
> On 2017/03/23 20:24:56, klausw wrote:
> > mailto:bajones@chromium.org: This is a cherry-pick, can you confirm the
> changes to
> > VRDisplay.* match those in https://codereview.chromium.org/2748293002 ?
> 
> lgtm

Lgtm

[klausw, 2017-03-23 20:48:48]

The CQ bit was checked by klausw@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:55:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490302128052500,
"parent_rev": "d9e025babf3ed584560c602f7a1adbd7a9d5f8c2", "commit_rev":
"40b2aa9268c6ff790dd6691bac26b5e15799852e"}

[commit-bot: I haz the power, 2017-03-23 20:56:00]

Description was changed from

==========
WebVR: process animations from posted task to yield for other events

If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.

BUG=701444
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)
==========

to

==========
WebVR: process animations from posted task to yield for other events

If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.

BUG=701444
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)

Review-Url: https://codereview.chromium.org/2774673003
Cr-Commit-Position: refs/branch-heads/3029@{#394}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/40b2aa9268c6ff790dd6691bac26...
==========

[commit-bot: I haz the power, 2017-03-23 20:56:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40b2aa9268c6ff790dd6691bac26...

[haraken, 2017-03-24 01:16:05]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-03-24 01:16:06]

https://codereview.chromium.org/2774673003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right):

https://codereview.chromium.org/2774673003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/VRDisplay.cpp:727:
Platform::current()->currentThread()->getWebTaskRunner()->postTask(

The default task runner is going to be deprecated. Use
TaskRunnerHelper::postTask() instead.

See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebTh...