Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2752343002: WebVR: move animation state check to deferred task (Closed)

Created:
3 years, 9 months ago by klausw
Modified:
3 years, 9 months ago
Reviewers:
mthiesse, bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: move animation state check to deferred task The animation controller or document may have disappeared in between scheduling the callback and executing it. BUG=701444 R=bajones, mthiesse Review-Url: https://codereview.chromium.org/2752343002 Cr-Commit-Position: refs/heads/master@{#457618} Committed: https://chromium.googlesource.com/chromium/src/+/efd3d31152e48d1089175b9256c56bccbe6d9792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
klausw
Not sure if this went out for review already, resending just in case.
3 years, 9 months ago (2017-03-16 22:22:25 UTC) #1
mthiesse
lgtm
3 years, 9 months ago (2017-03-16 22:24:46 UTC) #2
bajones
LGTM
3 years, 9 months ago (2017-03-16 22:32:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752343002/1
3 years, 9 months ago (2017-03-16 22:34:37 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 00:14:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efd3d31152e48d1089175b9256c5...

Powered by Google App Engine
This is Rietveld 408576698