|
|
DescriptionSplit user metrics for window proxy initialization.
Currently we have two UMA to measure time spent in window proxies initialization
- Blink.Binding.InitializeMainWindowProxy
- Blink.Binding.InitializeNonMainWindowProxy
but now WindowProxy was split into LocalWP and RemoteWP.
https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b4afc3501cd94
So I would like to split those UMAs to track performance more precisely.
- Blink.Binding.InitializeMainLocalWindowProxy
- Blink.Binding.InitializeMainRemoteWindowProxy
- Blink.Binding.InitializeNonMainLocalWindowProxy
- Blink.Binding.InitializeNonMainRemoteWindowProxy
BUG=588893
Review-Url: https://codereview.chromium.org/2771723005
Cr-Commit-Position: refs/heads/master@{#459705}
Committed: https://chromium.googlesource.com/chromium/src/+/dd92156efac57169b45aeb0094111b8d94302b12
Patch Set 1 : . #Patch Set 2 : Split main frame metric #
Depends on Patchset: Messages
Total messages: 26 (16 generated)
Description was changed from ========== Split UMAs for window proxy initialization BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and their initialization phase are different. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split UMA too, to track performance more precisely. BUG=588893 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by peria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and their initialization phase are different. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split UMA too, to track performance more precisely. BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ==========
Description was changed from ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainWindowProxy (as-is) - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ==========
peria@chromium.org changed reviewers: + dcheng@chromium.org, haraken@chromium.org, yukishiino@chromium.org
PTL
On 2017/03/24 08:10:32, peria (slow this week) wrote: > PTL I'll add an OWNER of histograms.xml after your reviews.
On 2017/03/24 08:12:29, peria (slow this week) wrote: > On 2017/03/24 08:10:32, peria (slow this week) wrote: > > PTL > > I'll add an OWNER of histograms.xml after your reviews. Per the other CL, we can have remote window proxies for the main frame. Though I'm not sure we actually need to distinguish between main frame and non main frame time for remote window proxy, it can't hurt. (Sorry for missing this in my CL: it was in my to-do list to split this uma, but then I missed it)
On 2017/03/24 08:20:54, dcheng wrote: > On 2017/03/24 08:12:29, peria (slow this week) wrote: > > On 2017/03/24 08:10:32, peria (slow this week) wrote: > > > PTL > > > > I'll add an OWNER of histograms.xml after your reviews. > > Per the other CL, we can have remote window proxies for the main frame. Though > I'm not sure we actually need to distinguish between main frame and non main > frame time for remote window proxy, it can't hurt. > > (Sorry for missing this in my CL: it was in my to-do list to split this uma, but > then I missed it) No problem ;) Then, I'll simply split each original metric into 2. (mainWP --> mainLocalWP + mainRemoteWP, nonMainWP --> nonMainLocalWP + nonMainRemoteWP) We can obsolete or just ignore some results, if we don't need them.
PTAL
Defer to dcheng@. LGTM on my side.
LGTM (You need to ask review for histograms.)
LGTM
Description was changed from ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainWindowProxy (as-is) - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ==========
Description was changed from ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP, and RemoteWP works only for non main frames. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split NonMainWindowProxy to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split those UMAs to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ==========
The CQ bit was checked by peria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490586227863560, "parent_rev": "9e4242231a21fb5ebdc990ad3cbc50b9afdf00d3", "commit_rev": "dd92156efac57169b45aeb0094111b8d94302b12"}
Message was sent while issue was closed.
Description was changed from ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split those UMAs to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 ========== to ========== Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b... So I would like to split those UMAs to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 Review-Url: https://codereview.chromium.org/2771723005 Cr-Commit-Position: refs/heads/master@{#459705} Committed: https://chromium.googlesource.com/chromium/src/+/dd92156efac57169b45aeb009411... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/dd92156efac57169b45aeb009411... |