Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 2771723005: [Bindings][UMA] Split user metrics for window proxy initialization (Closed)

Created:
3 years, 9 months ago by peria
Modified:
3 years, 9 months ago
Reviewers:
haraken, dcheng, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split user metrics for window proxy initialization. Currently we have two UMA to measure time spent in window proxies initialization - Blink.Binding.InitializeMainWindowProxy - Blink.Binding.InitializeNonMainWindowProxy but now WindowProxy was split into LocalWP and RemoteWP. https://chromium.googlesource.com/chromium/src/+/690c3cf203b94623e5adbece7d6b4afc3501cd94 So I would like to split those UMAs to track performance more precisely. - Blink.Binding.InitializeMainLocalWindowProxy - Blink.Binding.InitializeMainRemoteWindowProxy - Blink.Binding.InitializeNonMainLocalWindowProxy - Blink.Binding.InitializeNonMainRemoteWindowProxy BUG=588893 Review-Url: https://codereview.chromium.org/2771723005 Cr-Commit-Position: refs/heads/master@{#459705} Committed: https://chromium.googlesource.com/chromium/src/+/dd92156efac57169b45aeb0094111b8d94302b12

Patch Set 1 : . #

Patch Set 2 : Split main frame metric #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +43 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (16 generated)
peria
PTL
3 years, 9 months ago (2017-03-24 08:10:32 UTC) #12
peria
On 2017/03/24 08:10:32, peria (slow this week) wrote: > PTL I'll add an OWNER of ...
3 years, 9 months ago (2017-03-24 08:12:29 UTC) #13
dcheng
On 2017/03/24 08:12:29, peria (slow this week) wrote: > On 2017/03/24 08:10:32, peria (slow this ...
3 years, 9 months ago (2017-03-24 08:20:54 UTC) #14
peria
On 2017/03/24 08:20:54, dcheng wrote: > On 2017/03/24 08:12:29, peria (slow this week) wrote: > ...
3 years, 9 months ago (2017-03-24 08:37:12 UTC) #15
peria
PTAL
3 years, 9 months ago (2017-03-24 09:29:43 UTC) #16
Yuki
Defer to dcheng@. LGTM on my side.
3 years, 9 months ago (2017-03-24 10:21:50 UTC) #17
haraken
LGTM (You need to ask review for histograms.)
3 years, 9 months ago (2017-03-24 10:23:38 UTC) #18
dcheng
LGTM
3 years, 9 months ago (2017-03-27 02:44:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771723005/80001
3 years, 9 months ago (2017-03-27 03:44:17 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 05:13:16 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dd92156efac57169b45aeb009411...

Powered by Google App Engine
This is Rietveld 408576698