Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 2773073002: [Bindings] Add DCHECK to confirm RemoteWindowProxy is not used for main frame (Closed)

Created:
3 years, 9 months ago by peria
Modified:
3 years, 9 months ago
Reviewers:
haraken, dcheng, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK to confirm RemoteWindowProxy is not used for main frame BUG=527190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (7 generated)
peria
PTL This CL is a prepare for another one. https://codereview.chromium.org/2771723005
3 years, 9 months ago (2017-03-24 08:10:23 UTC) #6
dcheng
On 2017/03/24 08:10:23, peria (slow this week) wrote: > PTL > > This CL is ...
3 years, 9 months ago (2017-03-24 08:14:24 UTC) #7
peria
3 years, 9 months ago (2017-03-24 08:26:11 UTC) #8
On 2017/03/24 08:14:24, dcheng wrote:
> On 2017/03/24 08:10:23, peria (slow this week) wrote:
> > PTL
> > 
> > This CL is a prepare for another one.
> > https://codereview.chromium.org/2771723005
> 
> The main frame can be remote though, which means it would use
RemoteWindowProxy.

Oh, that's sad. It was the concern and the reason to put this DCHECK().
Then, I'll cancel this CL and update the following CL with the assumption.


thanks

Powered by Google App Engine
This is Rietveld 408576698