third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp - Issue 2771723005: [Bindings][UMA] Split user metrics for window proxy initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

Issue 2771723005: [Bindings][UMA] Split user metrics for window proxy initialization (Closed)

Patch Set: Split main frame metric Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

index b484ebebf77af1fdef5e85805b71e2726b195a3d..c60566d5abe83d86e490e13ef07d00382df0cc0e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

@@ -69,8 +69,9 @@ void RemoteWindowProxy::initialize() {

TRACE_EVENT1("v8", "RemoteWindowProxy::initialize", "isMainWindow",

frame()->isMainFrame());

SCOPED_BLINK_UMA_HISTOGRAM_TIMER(

- frame()->isMainFrame() ? "Blink.Binding.InitializeMainWindowProxy"

- : "Blink.Binding.InitializeNonMainWindowProxy");

+ frame()->isMainFrame()

+ ? "Blink.Binding.InitializeMainRemoteWindowProxy"

+ : "Blink.Binding.InitializeNonMainRemoteWindowProxy");

ScriptForbiddenScope::AllowUserAgentScript allowScript;