Revert of Move geometry interface files to geometry directory.

Revert of Move geometry interface files to geometry directory. (patchset #7 id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzczZjIyMDg4ZWIyYzk0ZGY0MmVkZDU1YWJkOWNmMWUzNDVlMThlN2MM

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed: https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9cf1e345e18e7c

###########################################################
# Remove original metadata to test CLA.
# Will check CQ box, and then quickly uncheck it before it pass CQ.
###########################################################

[findit-for-me, 2017-03-24 12:42:21]

Created Revert of Move geometry interface files to geometry directory.

[findit-for-me, 2017-03-24 12:42:23]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ avi@google.com, ksakamoto@google.com, melandory@google.com, wittman@google.com

[findit-for-me, 2017-03-24 12:42:23]

Sheriffs:

Please confirm and commit this reverting CL if it is the right fix.
The original CL was identified as the culprit for failures in the build
cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[blink-reviews, 2017-03-24 12:56:12]

Looks like findit found correct CL. Will stare at it a bit, to convince
myself completely and then revert

On Mar 24, 2017 1:42 PM, "findit-for-me@appspot.gserviceaccount.com via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

>
> Sheriffs:
>
> Please confirm and commit this reverting CL if it is the right fix.
> The original CL was identified as the culprit for failures in the build
> cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=
> ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVt
> LzczZjIyMDg4ZWIyYzk0ZGY0MmVkZDU1YWJkOWNmMWUzNDVlMThlN2MM
>
> https://codereview.chromium.org/2771683005/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-03-24 12:57:18]

Looks like findit found correct CL. Will stare at it a bit, to convince
myself completely and then revert

On Mar 24, 2017 1:42 PM, "findit-for-me@appspot.gserviceaccount.com via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

>
> Sheriffs:
>
> Please confirm and commit this reverting CL if it is the right fix.
> The original CL was identified as the culprit for failures in the build
> cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=
> ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVt
> LzczZjIyMDg4ZWIyYzk0ZGY0MmVkZDU1YWJkOWNmMWUzNDVlMThlN2MM
>
> https://codereview.chromium.org/2771683005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[melandory, 2017-03-24 13:13:13]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2017-03-24 13:13:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 13:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 13:13:30]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[zino, 2017-03-24 13:14:00]

On 2017/03/24 13:13:30, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

lgtm

[zino, 2017-03-24 13:14:06]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-03-24 13:14:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 13:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 13:14:26]

The author findit-for-me@appspot.gserviceaccount.com has not signed Google
Contributor License Agreement. Please visit https://cla.developers.google.com to
sign and manage CLA.

[melandory, 2017-03-24 13:26:39]

On 2017/03/24 13:14:26, commit-bot: I haz the power wrote:
> The author mailto:findit-for-me@appspot.gserviceaccount.com has not signed
Google
> Contributor License Agreement. Please visit https://cla.developers.google.com
to
> sign and manage CLA.

I'm not sure how to proceed with this revert and this error. Reverting using
usual retvield mechanism

[melandory, 2017-03-24 13:41:57]

Description was changed from

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

TBR=dominicc@chromium.org,foolip@chromium.org,jinho.bang@samsung.com,esprehn@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581955
==========

to

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

TBR=dominicc@chromium.org,foolip@chromium.org,jinho.bang@samsung.com,esprehn@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581955
==========

[stgao, 2017-03-30 01:05:10]

stgao@chromium.org changed reviewers:
- avi@google.com, dominicc@chromium.org, esprehn@chromium.org,
foolip@chromium.org, gogag2@gmail.com, jinho.bang@samsung.com,
ksakamoto@google.com, melandory@chromium.org, melandory@google.com,
wittman@google.com

[stgao, 2017-03-30 01:06:58]

Description was changed from

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

TBR=dominicc@chromium.org,foolip@chromium.org,jinho.bang@samsung.com,esprehn@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581955
==========

to

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

# Skipping CQ checks because original CL landed less than 1 days ago.
# Remove original metadata to test CLA.
# Will check CQ box, and then uncheck it before it pass CQ.
==========

[stgao, 2017-03-30 01:09:04]

The CQ bit was checked by stgao@chromium.org

[stgao, 2017-03-30 01:09:37]

The CQ bit was unchecked by stgao@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:09:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stgao, 2017-03-30 01:11:19]

Description was changed from

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

# Skipping CQ checks because original CL landed less than 1 days ago.
# Remove original metadata to test CLA.
# Will check CQ box, and then uncheck it before it pass CQ.
==========

to

==========
Revert of Move geometry interface files to geometry directory. (patchset #7
id:120001 of https://codereview.chromium.org/2741723005/ )

Reason for revert:

Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Move geometry interface files to geometry directory.
> 
> The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
> in a lot of modules such as dom, css and so on. Also, it is not very relevant
to
>  the DOM, so it is proper to create a new geometry directory and then move the
>  related files to the directory.
> 
> [1/2] This Patch (Move DOMMatrix related files to geometry folder)
> [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
>  alias of DOMMatrix.)
> 
> BUG=581955
> 
> Review-Url: https://codereview.chromium.org/2741723005
> Cr-Commit-Position: refs/heads/master@{#459398}
> Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

###########################################################
# Remove original metadata to test CLA.
# Will check CQ box, and then quickly uncheck it before it pass CQ.
###########################################################
==========

[stgao, 2017-03-30 01:11:44]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:13:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stgao, 2017-03-30 01:15:15]

The CQ bit was unchecked by stgao@chromium.org