Move geometry interface files to geometry directory.

Move geometry interface files to geometry directory.

The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
in a lot of modules such as dom, css and so on. Also, it is not very relevant to
 the DOM, so it is proper to create a new geometry directory and then move the
 related files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
Review-Url: https://codereview.chromium.org/2741723005
Cr-Commit-Position: refs/heads/master@{#459398}
Committed: https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9cf1e345e18e7c

[Byoungkwon Ko, 2017-03-11 14:06:04]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 14:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 14:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 14:09:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Byoungkwon Ko, 2017-03-12 11:57:06]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 11:57:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-03-12 12:12:47]

Description was changed from

==========
test for alias

BUG=
==========

to

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 12:31:34]

gogag2@gmail.com changed reviewers:
+ dominicc@chromium.org, foolip@chromium.org, jinho.bang@samsung.com

[Byoungkwon Ko, 2017-03-12 12:32:57]

gogag2@gmail.com changed reviewers:
- dominicc@chromium.org, foolip@chromium.org, jinho.bang@samsung.com

[Byoungkwon Ko, 2017-03-12 13:22:11]

Description was changed from

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

BUG=581955
==========

to

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] https://codereview.chromium.org/2741723005 (Create geometry folder and
 move related files.)
[2/2] WIP (Move WebKitCSSMatrix.idl from css/ to geometry)

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 14:23:51]

Description was changed from

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] https://codereview.chromium.org/2741723005 (Create geometry folder and
 move related files.)
[2/2] WIP (Move WebKitCSSMatrix.idl from css/ to geometry)

BUG=581955
==========

to

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] This Patch (Move DOMMatrix related files.)
[2/2] Make WebKitCSSMatrix an alias of DOMMatrix.

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 14:25:12]

Description was changed from

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] This Patch (Move DOMMatrix related files.)
[2/2] Make WebKitCSSMatrix an alias of DOMMatrix.

BUG=581955
==========

to

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] Make WebKitCSSMatrix an alias of DOMMatrix.

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 14:37:09]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 14:37:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-03-12 15:52:24]

Description was changed from

==========
Make WebkitCSSMatrix an alias of DOMMatrix
DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple
alias of it.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] Make WebKitCSSMatrix an alias of DOMMatrix.

BUG=581955
==========

to

==========
Move DOMMatrix related files to geometry folder.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 15:52:24]

gogag2@gmail.com changed reviewers:
+ dominicc@chromium.org, foolip@chromium.org, jinho.bang@samsung.com

[Byoungkwon Ko, 2017-03-12 15:54:01]

gogag2@gmail.com changed reviewers:
- dominicc@chromium.org

[Byoungkwon Ko, 2017-03-12 15:56:25]

PTAL

[Byoungkwon Ko, 2017-03-12 16:04:38]

Description was changed from

==========
Move DOMMatrix related files to geometry folder.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

to

==========
Move geometry interface files to geometry folder.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

[Byoungkwon Ko, 2017-03-12 16:05:03]

Description was changed from

==========
Move geometry interface files to geometry folder.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

to

==========
Move geometry interface files to geometry directory.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

[commit-bot: I haz the power, 2017-03-12 16:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 16:09:39]

Dry run: This issue passed the CQ dry run.

[zino, 2017-03-14 14:23:35]

On 2017/03/12 15:56:25, Byoungkwon Ko wrote:
> PTAL

looks good to me but you should wait for foolip@'s comment.

[foolip, 2017-03-14 14:38:42]

foolip@chromium.org changed reviewers:
+ dominicc@chromium.org

[foolip, 2017-03-14 14:38:44]

lgtm, but please wait to see if dominicc@ wants to be in the OWNERS file or not.

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h:8: #include <memory>
Did a presubmit ask you to move <memory> up? AFAICT, this header is usually
after the "local" includes.

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/geometry/OWNERS (right):

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/geometry/OWNERS:1: dominicc@chromium.org
domincc@, are you OK with this, have you poked at the geometry interfaces
before?

[dominicc (has gone to gerrit), 2017-03-16 00:09:52]

dominicc@chromium.org changed reviewers:
+ esprehn@chromium.org

[dominicc (has gone to gerrit), 2017-03-16 00:09:53]

I'm fine with being in OWNERS since I reviewed a bunch of it and too few OWNERS
can make life harder later.

esprehn, I know you pushed back on creating a directory for modules; how do you
feel about creating this directory?

[esprehn, 2017-03-22 00:25:26]

On 2017/03/16 at 00:09:53, dominicc wrote:
> I'm fine with being in OWNERS since I reviewed a bunch of it and too few
OWNERS can make life harder later.
> 
> esprehn, I know you pushed back on creating a directory for modules; how do
you feel about creating this directory?

lgtm, this is a ton of code and related web platform concepts. If we ever
implemented that giant module loader JS API we'd probably need a directory for
that too.

Fwiw I really do think we should drop the CSS parsing feature of DOMMatrix, if
we did that the geometry directory would be completely stand lone and disjoint
of the rest of the DOM and CSS surface and very easy to expose in any JS
context. Typed OM is a much better place for CSS parsing, not randomly inside
our geometry types, just like having SkMatrix parse a CSS transform would be
super weird.

WebKitCSSMatrix can remain as a function that returns a DOMMatrix by doing the
CSS parsing, just like we have Image(width, height) and HTMLImageElement(void).

[foolip, 2017-03-22 04:18:29]

On 2017/03/22 00:25:26, esprehn wrote:
> On 2017/03/16 at 00:09:53, dominicc wrote:
> > I'm fine with being in OWNERS since I reviewed a bunch of it and too few
> OWNERS can make life harder later.
> > 
> > esprehn, I know you pushed back on creating a directory for modules; how do
> you feel about creating this directory?
> 
> lgtm, this is a ton of code and related web platform concepts. If we ever
> implemented that giant module loader JS API we'd probably need a directory for
> that too.
> 
> Fwiw I really do think we should drop the CSS parsing feature of DOMMatrix, if
> we did that the geometry directory would be completely stand lone and disjoint
> of the rest of the DOM and CSS surface and very easy to expose in any JS
> context. Typed OM is a much better place for CSS parsing, not randomly inside
> our geometry types, just like having SkMatrix parse a CSS transform would be
> super weird.
> 
> WebKitCSSMatrix can remain as a function that returns a DOMMatrix by doing the
> CSS parsing, just like we have Image(width, height) and
HTMLImageElement(void).

A WebKitCSSMatrix named constructor would work if that was the only place that
did the parsing, but there's also the setMatrixValue method which does the same
thing as the DOMString constructor. Both of these are supported in Gecko as
well. But let's come to some agreement on the intent thread.

[Byoungkwon Ko, 2017-03-22 15:33:34]

dear reviewers.

could I commit it??

[zino, 2017-03-22 16:01:24]

On 2017/03/22 15:33:34, Byoungkwon Ko wrote:
> dear reviewers.
> 
> could I commit it??

lgtm.

In your first patch, this patch blocked your alias patch because you'd like to
use "ImplementedAs".
But you are not using "ImplementedAs" anymore according to foolip@'s input as
well as this patch doesn't seem to be related to remaining issues.
Therefore, I think you can commit this patch regardless of the unresolved
issues.

Please update the commit description before landing this.

[zino, 2017-03-22 16:08:40]

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h:8: #include <memory>
On 2017/03/14 14:38:43, foolip_UTC9 wrote:
> Did a presubmit ask you to move <memory> up? AFAICT, this header is usually
> after the "local" includes.

Ah, please fix foolip@'s comment as well before landing.

[foolip, 2017-03-23 06:42:33]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-03-23 06:42:34]

lgtm

If this only moves files around and doesn't change any web exposed behavior at
all, which seems to be the case, then please go ahead and land it. We'll still
have to come to some agreement about the parsing behavior of WebKitCSSMatrix,
but that's a separate issue.

[commit-bot: I haz the power, 2017-03-23 06:42:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 07:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 07:13:26]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Byoungkwon Ko, 2017-03-23 17:01:32]

Description was changed from

==========
Move geometry interface files to geometry directory.

After this change, to make alias of WebKitCSSMatrix, we want to use
"ImplementedAs" keyword in IDL. Then, we can cover many duplicated functions
without additional c++ implementation. For that being true, we will have to put
the IDL files and C++ implementations into the same directory. But the geometry
interfaces such as DOMMatrix, DOMRect and so on can be shared in a lot of
modules such as dom, css and so on. Also, it is not very relevant to the DOM,
so it is proper to create a new geometry directory and then move the related
files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

to

==========
Move geometry interface files to geometry directory.

The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
in a lot of modules such as dom, css and so on. Also, it is not very relevant to
 the DOM, so it is proper to create a new geometry directory and then move the
 related files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

[Byoungkwon Ko, 2017-03-23 17:02:37]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[Byoungkwon Ko, 2017-03-23 17:03:19]

@foolip 

I fixed the location of <memory>.

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2741723005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h:8: #include <memory>
On 2017/03/14 14:38:43, foolip_UTC9 wrote:
> Did a presubmit ask you to move <memory> up? AFAICT, this header is usually
> after the "local" includes.

Yes, As you told, presubmit ask me to move <memory> up. 
So I used command "git cl format -- ...".
I fixed the location below "local" includes.
Thanks.

[commit-bot: I haz the power, 2017-03-23 17:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-03-23 17:04:10]

On 2017/03/22 16:01:24, zino wrote:
> On 2017/03/22 15:33:34, Byoungkwon Ko wrote:
> > dear reviewers.
> > 
> > could I commit it??
> 
> lgtm.
> 
> In your first patch, this patch blocked your alias patch because you'd like to
> use "ImplementedAs".
> But you are not using "ImplementedAs" anymore according to foolip@'s input as
> well as this patch doesn't seem to be related to remaining issues.
> Therefore, I think you can commit this patch regardless of the unresolved
> issues.
> 
> Please update the commit description before landing this.

@zino

I fixed description.
Thanks.

[commit-bot: I haz the power, 2017-03-23 17:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:56:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Byoungkwon Ko, 2017-03-24 03:37:41]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2017-03-24 03:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, foolip@chromium.org, jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2741723005/#ps100001
(title: "Move geometry interface files to geometry directory.")

[commit-bot: I haz the power, 2017-03-24 03:38:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:46:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Byoungkwon Ko, 2017-03-24 09:00:23]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:08:15]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-03-24 09:12:45]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:20:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-03-24 09:45:39]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:45:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 12:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 12:01:23]

Dry run: This issue passed the CQ dry run.

[Byoungkwon Ko, 2017-03-24 12:19:41]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2017-03-24 12:19:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, foolip@chromium.org, jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2741723005/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-24 12:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 12:25:34]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490357981702630,
"parent_rev": "17fdf91928a59764dc695227ee872403cc8f6ea6", "commit_rev":
"73f22088eb2c94df42edd55abd9cf1e345e18e7c"}

[commit-bot: I haz the power, 2017-03-24 12:26:21]

Description was changed from

==========
Move geometry interface files to geometry directory.

The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
in a lot of modules such as dom, css and so on. Also, it is not very relevant to
 the DOM, so it is proper to create a new geometry directory and then move the
 related files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955
==========

to

==========
Move geometry interface files to geometry directory.

The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared 
in a lot of modules such as dom, css and so on. Also, it is not very relevant to
 the DOM, so it is proper to create a new geometry directory and then move the
 related files to the directory.

[1/2] This Patch (Move DOMMatrix related files to geometry folder)
[2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an
 alias of DOMMatrix.)

BUG=581955

Review-Url: https://codereview.chromium.org/2741723005
Cr-Commit-Position: refs/heads/master@{#459398}
Committed:
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...
==========

[commit-bot: I haz the power, 2017-03-24 12:26:24]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/73f22088eb2c94df42edd55abd9c...

[findit-for-me, 2017-03-24 12:42:21]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2771683005/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 459398 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[melandory, 2017-03-24 13:26:13]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2770253003/ by melandory@chromium.org.

The reason for reverting is: Findit identified CL at revision 459398 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[zino, 2017-03-24 13:33:47]

On 2017/03/24 13:26:13, melandory wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/2770253003/ by mailto:melandory@chromium.org.
> 
> The reason for reverting is: Findit identified CL at revision 459398 as the
> culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

gogag@,

You had to update bindings/core/v8/BUILD.gn as well.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...