[WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

DocumentMarkerController refactor part 7

After https://codereview.chromium.org/2765133002 (part 6),
DocumentMarkerController has these methods for adding markers:

addSpellingMarker()
addGrammarMarker()
addTextMatchMarker()
addCompositionMarker()

addTextMatchMarker() takes a reference to an EphemeralRange but the other
methods take two Position references. This CL unifies these methods to all take
an EphemeralRange.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

BUG=707867

[rlanday, 2017-03-22 20:36:16]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-03-22 20:36:17]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[rlanday, 2017-03-22 20:36:22]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 20:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-22 21:11:36]

Should the DocumentMarker::create*Marker() methods also take an EphemeralRange?

[rlanday, 2017-03-22 21:14:14]

On 2017/03/22 at 21:11:36, rlanday wrote:
> Should the DocumentMarker::create*Marker() methods also take an
EphemeralRange?

Uhh nevermind, this question doesn't make sense, the
DocumentMarker::create*Marker() methods take a pair of offsets into their node,
not a Position pair

[Xiaocheng, 2017-03-22 21:21:01]

lgtm

https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:551: if (type
== DocumentMarker::Grammar) {
nit: no need to have braces now.

https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:977: if (type ==
DocumentMarker::Grammar) {
nit: no need to have braces now.

[rlanday, 2017-03-22 22:06:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:07:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:36:59]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-03-29 23:55:11]

Description was changed from

==========
Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

DocumentMarkerController refactor part 7

After https://codereview.chromium.org/2765133002 (part 6),
DocumentMarkerController has these methods for adding markers:

addSpellingMarker()
addGrammarMarker()
addTextMatchMarker()
addCompositionMarker()

addTextMatchMarker() takes a reference to an EphemeralRange but the other
methods take two Position references. This CL unifies these methods to all take
an EphemeralRange.
==========

to

==========
Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

DocumentMarkerController refactor part 7

After https://codereview.chromium.org/2765133002 (part 6),
DocumentMarkerController has these methods for adding markers:

addSpellingMarker()
addGrammarMarker()
addTextMatchMarker()
addCompositionMarker()

addTextMatchMarker() takes a reference to an EphemeralRange but the other
methods take two Position references. This CL unifies these methods to all take
an EphemeralRange.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-03-31 01:58:04]

On 2017/03/22 at 21:21:01, xiaochengh wrote:
> lgtm
> 
>
https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
(right):
> 
>
https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:551: if
(type == DocumentMarker::Grammar) {
> nit: no need to have braces now.
> 
>
https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/testing/Internals.cpp (right):
> 
>
https://codereview.chromium.org/2771603002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/testing/Internals.cpp:977: if (type ==
DocumentMarker::Grammar) {
> nit: no need to have braces now.

Updated

[rlanday, 2017-04-03 18:56:05]

Description was changed from

==========
Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

DocumentMarkerController refactor part 7

After https://codereview.chromium.org/2765133002 (part 6),
DocumentMarkerController has these methods for adding markers:

addSpellingMarker()
addGrammarMarker()
addTextMatchMarker()
addCompositionMarker()

addTextMatchMarker() takes a reference to an EphemeralRange but the other
methods take two Position references. This CL unifies these methods to all take
an EphemeralRange.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange

DocumentMarkerController refactor part 7

After https://codereview.chromium.org/2765133002 (part 6),
DocumentMarkerController has these methods for adding markers:

addSpellingMarker()
addGrammarMarker()
addTextMatchMarker()
addCompositionMarker()

addTextMatchMarker() takes a reference to an EphemeralRange but the other
methods take two Position references. This CL unifies these methods to all take
an EphemeralRange.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

BUG=707867
==========