Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2771603002: [WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/Internals.cpp
diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp
index 3eb62d9183c990e67e9c1313b63394453e746d94..aa996eb98278daa38d4b086a9bad219491c5de3f 100644
--- a/third_party/WebKit/Source/core/testing/Internals.cpp
+++ b/third_party/WebKit/Source/core/testing/Internals.cpp
@@ -925,14 +925,12 @@ void Internals::setMarker(Document* document,
document->updateStyleAndLayoutIgnorePendingStylesheets();
if (type == DocumentMarker::Grammar) {
- document->markers().addGrammarMarker(range->startPosition(),
- range->endPosition());
+ document->markers().addGrammarMarker(EphemeralRange(range));
return;
}
if (type == DocumentMarker::Spelling) {
- document->markers().addSpellingMarker(range->startPosition(),
- range->endPosition());
+ document->markers().addSpellingMarker(EphemeralRange(range));
return;
}
@@ -1063,8 +1061,7 @@ void Internals::addCompositionMarker(const Range* range,
parseColor(backgroundColorValue, backgroundColor, exceptionState,
"Invalid background color.")) {
range->ownerDocument().markers().addCompositionMarker(
- range->startPosition(), range->endPosition(), underlineColor, thick,
- backgroundColor);
+ EphemeralRange(range), underlineColor, thick, backgroundColor);
}
}

Powered by Google App Engine
This is Rietveld 408576698