Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2771603002: [WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index 78c73cd0908da776e1b01e90852e6e09e0df1623..f6b7736e6a18e64014f281ff647dea1c815e5e6d 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -55,15 +55,12 @@ class CORE_EXPORT DocumentMarkerController final
void clear();
void addMarker(Node*, DocumentMarker*);
- void addSpellingMarker(const Position& start,
- const Position& end,
+ void addSpellingMarker(const EphemeralRange&,
const String& description = emptyString);
- void addGrammarMarker(const Position& start,
- const Position& end,
+ void addGrammarMarker(const EphemeralRange&,
const String& description = emptyString);
void addTextMatchMarker(const EphemeralRange&, bool activeMatch);
- void addCompositionMarker(const Position& start,
- const Position& end,
+ void addCompositionMarker(const EphemeralRange&,
Color underlineColor,
bool thick,
Color backgroundColor);
@@ -138,8 +135,7 @@ class CORE_EXPORT DocumentMarkerController final
private:
using MarkerMap = HeapHashMap<WeakMember<Node>, Member<DocumentMarkerList>>;
- void addGrammarOrSpellingMarker(const Position& start,
- const Position& end,
+ void addGrammarOrSpellingMarker(const EphemeralRange&,
DocumentMarker::MarkerType,
const String& description);
DocumentMarkerList* createMarkerListOfType(DocumentMarker::MarkerType);

Powered by Google App Engine
This is Rietveld 408576698