[WIP] Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

Depends on https://codereview.chromium.org/2780313002 (Refactor DocumentMarker)

After this CL, we will have a 1-to-1 mapping between DocumentMarkerController's add*Marker() methods and the list of marker types.

BUG=707867

[rlanday, 2017-03-22 01:46:27]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 01:47:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-22 01:47:16]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-03-22 01:47:17]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-03-22 02:00:29]

lgtm with nits.

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(left):

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:103:
void DocumentMarkerController::addCompositionMarker(const Position& start,
nit: Shouldn't move this function.

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
(left):

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:61:
void addTextMatchMarker(const EphemeralRange&, bool activeMatch);
nit: Shouldn't move this line.

[commit-bot: I haz the power, 2017-03-22 03:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:49:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[yosin_UTC9, 2017-03-22 05:23:46]

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:63:
void DocumentMarkerController::addCompositionMarker(const Position& start,
Please move addCompositionMarker() changes to another CL.
This CL changes spelling and grammer markers.

[rlanday, 2017-03-22 17:21:52]

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:63:
void DocumentMarkerController::addCompositionMarker(const Position& start,
On 2017/03/22 at 05:23:46, yosin_UTC9 wrote:
> Please move addCompositionMarker() changes to another CL.
> This CL changes spelling and grammer markers.

I was just re-ordering the methods to put them in alphabetical order, but I'll
change it back, since neither you nor xiaochengh like this...

[rlanday, 2017-03-22 20:15:27]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 20:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-22 20:27:31]

On 2017/03/22 at 17:21:52, rlanday wrote:
>
https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
> File
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):
> 
>
https://codereview.chromium.org/2765133002/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:63:
void DocumentMarkerController::addCompositionMarker(const Position& start,
> On 2017/03/22 at 05:23:46, yosin_UTC9 wrote:
> > Please move addCompositionMarker() changes to another CL.
> > This CL changes spelling and grammer markers.
> 
> I was just re-ordering the methods to put them in alphabetical order, but I'll
change it back, since neither you nor xiaochengh like this...

Updated

[commit-bot: I haz the power, 2017-03-22 21:17:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:17:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-03-29 23:44:19]

Description was changed from

==========
Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

DocumentMarkerController refactor part 6

After https://codereview.chromium.org/2764743004 (part 5), we'll have a method
DocumentMarker::addMarker() that works for Grammar and Spelling markers. This CL
splits that method into addGrammarMarker() and addSpellingMarker() and updates
callsites to explicitly choose one of these methods.

Since Grammar and Spelling markers are so closely related, it didn't seem
helpful to split this into two CLs.
==========

to

==========
Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

Depends on https://codereview.chromium.org/2780313002 (Refactor DocumentMarker)

After this CL, we will have a 1-to-1 mapping between DocumentMarkerController's
add*Marker() methods and the list of marker types.
==========

[rlanday, 2017-03-29 23:44:50]

Rebased on https://codereview.chromium.org/2780313002 (Refactor DocumentMarker)

[yosin_UTC9, 2017-03-30 01:48:57]

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:71:
DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
nit: Could you add |<< type| for ease of debugging?

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:551:
DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
nit: Could you add |<< type| for ease of debugging?

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.cpp:924: if (type !=
DocumentMarker::Grammar && type != DocumentMarker::Spelling) {
Move this check at end of function to utilize early-return style.

https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.cpp:935:
document->markers().addGrammarMarker(range->startPosition(),
Let's use early return style.

[rlanday, 2017-03-31 01:48:42]

On 2017/03/30 at 01:48:57, yosin wrote:
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:71:
DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
> nit: Could you add |<< type| for ease of debugging?
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
(right):
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:551:
DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
> nit: Could you add |<< type| for ease of debugging?
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/testing/Internals.cpp (right):
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/testing/Internals.cpp:924: if (type !=
DocumentMarker::Grammar && type != DocumentMarker::Spelling) {
> Move this check at end of function to utilize early-return style.
> 
>
https://codereview.chromium.org/2765133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/testing/Internals.cpp:935:
document->markers().addGrammarMarker(range->startPosition(),
> Let's use early return style.

Updated

[rlanday, 2017-04-03 18:56:11]

Description was changed from

==========
Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

Depends on https://codereview.chromium.org/2780313002 (Refactor DocumentMarker)

After this CL, we will have a 1-to-1 mapping between DocumentMarkerController's
add*Marker() methods and the list of marker types.
==========

to

==========
Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

Depends on https://codereview.chromium.org/2780313002 (Refactor DocumentMarker)

After this CL, we will have a 1-to-1 mapping between DocumentMarkerController's
add*Marker() methods and the list of marker types.

BUG=707867
==========