MD Bookmarks: Validate URL input when editing a bookmark

MD Bookmarks: Validate URL input when editing a bookmark

This ensures that bookmarks can only be saved when they have a valid,
non-empty URL.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2769863002
Cr-Commit-Position: refs/heads/master@{#459718}
Committed: https://chromium.googlesource.com/chromium/src/+/e93a5f83b296e8294f0726f1426dbc2dbf131d33

[tsergeant, 2017-03-22 22:14:23]

Description was changed from

==========
MD Bookmarks: Validate URL input when editing a bookmark

This ensures that bookmarks can only be saved when they have a valid,
non-empty URL.

BUG=692821
==========

to

==========
MD Bookmarks: Validate URL input when editing a bookmark

This ensures that bookmarks can only be saved when they have a valid,
non-empty URL.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-03-22 22:32:25]

Patchset #1 (id:1) has been deleted

[tsergeant, 2017-03-22 22:32:46]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2017-03-22 22:33:05]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-03-22 22:33:06]

PTAL~

[commit-bot: I haz the power, 2017-03-22 22:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:13:27]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-03-24 04:57:45]

lgtm

https://codereview.chromium.org/2769863002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/edit_dialog.js (right):

https://codereview.chromium.org/2769863002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/edit_dialog.js:64: this.urlValue_ =
originalValue;
Urgh. This is a bit unfortunate. It's a shame you can't ask the input 'would X
be valid' =(

[tsergeant, 2017-03-27 05:15:37]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 05:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-03-27 05:31:44]

https://codereview.chromium.org/2769863002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/edit_dialog.js (right):

https://codereview.chromium.org/2769863002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/edit_dialog.js:64: this.urlValue_ =
originalValue;
On 2017/03/24 04:57:44, calamity wrote:
> Urgh. This is a bit unfortunate. It's a shame you can't ask the input 'would X
> be valid' =(

Yeah, it's a pity, but at least the URL field validation is a platform-level
thing that integrates relatively well with paper-input.

[tsergeant, 2017-03-27 05:33:34]

The CQ bit was unchecked by tsergeant@chromium.org

[tsergeant, 2017-03-27 05:34:07]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-03-27 05:34:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2769863002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-27 05:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:13:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-03-27 06:50:52]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:03:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490597452003980,
"parent_rev": "00dda6dbc09aa8a14805cbba3d78b5b1569620ca", "commit_rev":
"e93a5f83b296e8294f0726f1426dbc2dbf131d33"}

[commit-bot: I haz the power, 2017-03-27 08:04:19]

Description was changed from

==========
MD Bookmarks: Validate URL input when editing a bookmark

This ensures that bookmarks can only be saved when they have a valid,
non-empty URL.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Validate URL input when editing a bookmark

This ensures that bookmarks can only be saved when they have a valid,
non-empty URL.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2769863002
Cr-Commit-Position: refs/heads/master@{#459718}
Committed:
https://chromium.googlesource.com/chromium/src/+/e93a5f83b296e8294f0726f1426d...
==========

[commit-bot: I haz the power, 2017-03-27 08:04:20]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e93a5f83b296e8294f0726f1426d...