Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2769103002: MD Bookmarks: Save and close bookmark edit dialog on 'enter' key press. (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Save and close bookmark edit dialog on 'enter' key press. BUG=692821 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769103002 Cr-Commit-Position: refs/heads/master@{#459706} Committed: https://chromium.googlesource.com/chromium/src/+/da7f7baf81fd53e84850d1f7fbff478cc9b123b7

Patch Set 1 #

Patch Set 2 : Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/edit_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/edit_dialog.js View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_bookmarks/edit_dialog_test.js View 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
tsergeant
hooray!
3 years, 9 months ago (2017-03-23 04:58:31 UTC) #5
calamity
lgtm
3 years, 9 months ago (2017-03-24 04:18:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769103002/20001
3 years, 9 months ago (2017-03-26 22:31:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/408388)
3 years, 9 months ago (2017-03-27 00:34:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769103002/20001
3 years, 9 months ago (2017-03-27 04:47:27 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 05:24:56 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/da7f7baf81fd53e84850d1f7fbff...

Powered by Google App Engine
This is Rietveld 408576698