Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Issue 2769863002: MD Bookmarks: Validate URL input when editing a bookmark (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h" 5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 18 matching lines...) Expand all
29 29
30 content::WebUIDataSource* CreateMdBookmarksUIHTMLSource(Profile* profile) { 30 content::WebUIDataSource* CreateMdBookmarksUIHTMLSource(Profile* profile) {
31 content::WebUIDataSource* source = 31 content::WebUIDataSource* source =
32 content::WebUIDataSource::Create(chrome::kChromeUIBookmarksHost); 32 content::WebUIDataSource::Create(chrome::kChromeUIBookmarksHost);
33 33
34 // Localized strings (alphabetical order). 34 // Localized strings (alphabetical order).
35 AddLocalizedString(source, "cancelEdit", IDS_CANCEL); 35 AddLocalizedString(source, "cancelEdit", IDS_CANCEL);
36 AddLocalizedString(source, "clearSearch", 36 AddLocalizedString(source, "clearSearch",
37 IDS_MD_BOOKMARK_MANAGER_CLEAR_SEARCH); 37 IDS_MD_BOOKMARK_MANAGER_CLEAR_SEARCH);
38 AddLocalizedString(source, "editBookmarkTitle", IDS_BOOKMARK_EDITOR_TITLE); 38 AddLocalizedString(source, "editBookmarkTitle", IDS_BOOKMARK_EDITOR_TITLE);
39 AddLocalizedString(source, "editDialogInvalidUrl",
40 IDS_BOOKMARK_MANAGER_INVALID_URL);
39 AddLocalizedString(source, "editDialogNameInput", 41 AddLocalizedString(source, "editDialogNameInput",
40 IDS_BOOKMARK_MANAGER_NAME_INPUT_PLACE_HOLDER); 42 IDS_BOOKMARK_MANAGER_NAME_INPUT_PLACE_HOLDER);
41 AddLocalizedString(source, "editDialogUrlInput", 43 AddLocalizedString(source, "editDialogUrlInput",
42 IDS_BOOKMARK_MANAGER_URL_INPUT_PLACE_HOLDER); 44 IDS_BOOKMARK_MANAGER_URL_INPUT_PLACE_HOLDER);
43 AddLocalizedString(source, "emptyList", 45 AddLocalizedString(source, "emptyList",
44 IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST); 46 IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST);
45 AddLocalizedString(source, "menuAddBookmark", 47 AddLocalizedString(source, "menuAddBookmark",
46 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_BOOKMARK); 48 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_BOOKMARK);
47 AddLocalizedString(source, "menuAddFolder", 49 AddLocalizedString(source, "menuAddFolder",
48 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_FOLDER); 50 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_FOLDER);
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // Set up the chrome://bookmarks/ source. 118 // Set up the chrome://bookmarks/ source.
117 Profile* profile = Profile::FromWebUI(web_ui); 119 Profile* profile = Profile::FromWebUI(web_ui);
118 content::WebUIDataSource::Add(profile, 120 content::WebUIDataSource::Add(profile,
119 CreateMdBookmarksUIHTMLSource(profile)); 121 CreateMdBookmarksUIHTMLSource(profile));
120 } 122 }
121 123
122 // static 124 // static
123 bool MdBookmarksUI::IsEnabled() { 125 bool MdBookmarksUI::IsEnabled() {
124 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks); 126 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks);
125 } 127 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_bookmarks/edit_dialog.js ('k') | chrome/test/data/webui/md_bookmarks/edit_dialog_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698