Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2769403002: MIPS64: Fix code generator and simulator for DEXTM. (Closed)

Created:
3 years, 9 months ago by Ilija.Pavlovic1
Modified:
3 years, 9 months ago
Reviewers:
ivica.bogosavljevic, Benedikt Meurer, ilija.pavlovic, miran.karic, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix code generator and simulator for DEXTM. In code generator, DEXTM instruction will be emitted for intervals position=[0,31] and size=[33,64]. In simulator, mask for DEXTM will be calculated on correct way for size = 64. Disassembler has now possibility to disassemble instructions DEXTM and DEXTU. TEST=cctest/test-run-machops/Regression6122 BUG= Review-Url: https://codereview.chromium.org/2769403002 Cr-Commit-Position: refs/heads/master@{#44137} Committed: https://chromium.googlesource.com/v8/v8/+/a63ab810fc9dac1444d3e36d8b0faa95ea994fbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ilija.Pavlovic1
3 years, 9 months ago (2017-03-24 13:36:46 UTC) #2
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-03-24 13:37:11 UTC) #4
ivica.bogosavljevic
lgtm
3 years, 9 months ago (2017-03-24 13:38:26 UTC) #5
ahaas
On 2017/03/24 at 13:38:26, ivica.bogosavljevic wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-24 13:52:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769403002/1
3 years, 9 months ago (2017-03-27 06:31:42 UTC) #8
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-27 06:34:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 06:50:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a63ab810fc9dac1444d3e36d8b0faa95ea9...

Powered by Google App Engine
This is Rietveld 408576698