Only create sticky position constraints for constrained sticky position.

Only create sticky position constraints for constrained sticky position.

If sticky position is unconstrained we don't need to create constraints for it,
or add it to viewport constrained objects (causing scroll on main), or repaint
on scroll.

BUG=704817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2769353002
Cr-Commit-Position: refs/heads/master@{#463316}
Committed: https://chromium.googlesource.com/chromium/src/+/06e9b5a6a5649e4d842f40ad667554c58dc26c29

[flackr, 2017-03-24 04:43:53]

Description was changed from

==========
Only create sticky position constraints for constrained sticky position.

If sticky position is unconstrained we don't need to create constraints for it,
or add it to viewport constrained objects (causing scroll on main), or repaint
on scroll.

BUG=704817
==========

to

==========
Only create sticky position constraints for constrained sticky position.

If sticky position is unconstrained we don't need to create constraints for it,
or add it to viewport constrained objects (causing scroll on main), or repaint
on scroll.

BUG=704817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[flackr, 2017-03-24 04:47:39]

flackr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[flackr, 2017-03-24 04:47:40]

PTAL,

This is the final patch which basically avoids treating position sticky on its
own as special, unless it also has an anchor edge. This avoids repainting on
scroll, requiring scroll on main, and avoids calculating constraint rects that
we never use.

[chrishtr, 2017-03-27 16:28:07]

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:369:
ASSERT_TRUE(constraintsMap.contains(stickyInnerInline->layer()));
ASSERT_FALSE for unanchoredSticky?

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
(right):

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:104:
layer->layoutObject().style()->hasStickyConstrainedPosition()) {
Which code clears out the sticky position constraints when it becomes
unconstrained?

[flackr, 2017-04-07 18:15:45]

Sorry for the delay.

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:369:
ASSERT_TRUE(constraintsMap.contains(stickyInnerInline->layer()));
On 2017/03/27 16:28:07, chrishtr wrote:
> ASSERT_FALSE for unanchoredSticky?

Done.

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
(right):

https://codereview.chromium.org/2769353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:104:
layer->layoutObject().style()->hasStickyConstrainedPosition()) {
On 2017/03/27 16:28:07, chrishtr wrote:
> Which code clears out the sticky position constraints when it becomes
> unconstrained?

LayoutBoxModelObject::styleDidChange checks if the style became constrained or
no longer constrained and in the latter case removes the constraints from the
layer.

[chrishtr, 2017-04-07 20:49:08]

lgtm

[flackr, 2017-04-08 01:12:17]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:12:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 03:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 03:10:50]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[flackr, 2017-04-10 11:58:33]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2017-04-10 11:58:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 12:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 12:01:10]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[flackr, 2017-04-10 15:58:05]

The CQ bit was checked by flackr@chromium.org

[flackr, 2017-04-10 15:58:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2769353002/#ps60001
(title: "Merge with master.")

[commit-bot: I haz the power, 2017-04-10 15:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:51:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491839885568390,
"parent_rev": "0bfec0bfd3407138819f0e7a1439d74d6290ab53", "commit_rev":
"06e9b5a6a5649e4d842f40ad667554c58dc26c29"}

[commit-bot: I haz the power, 2017-04-10 17:52:40]

Description was changed from

==========
Only create sticky position constraints for constrained sticky position.

If sticky position is unconstrained we don't need to create constraints for it,
or add it to viewport constrained objects (causing scroll on main), or repaint
on scroll.

BUG=704817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Only create sticky position constraints for constrained sticky position.

If sticky position is unconstrained we don't need to create constraints for it,
or add it to viewport constrained objects (causing scroll on main), or repaint
on scroll.

BUG=704817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2769353002
Cr-Commit-Position: refs/heads/master@{#463316}
Committed:
https://chromium.googlesource.com/chromium/src/+/06e9b5a6a5649e4d842f40ad6675...
==========

[commit-bot: I haz the power, 2017-04-10 17:52:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/06e9b5a6a5649e4d842f40ad6675...

[Xi Han, 2017-04-10 21:30:11]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2811803003/ by hanxi@chromium.org.

The reason for reverting is: It causes telemetry_perf_unittests failing on
chromium.android/Android N5X Swarm Builder.

crbug.com/710142..