Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)
Patch Set: Merge with master. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1566 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 d->sticky_constraints_map_.Clear(); 1577 d->sticky_constraints_map_.Clear();
1578 } 1578 }
1579 } 1579 }
1580 1580
1581 void PaintLayerScrollableArea::InvalidateStickyConstraintsFor( 1581 void PaintLayerScrollableArea::InvalidateStickyConstraintsFor(
1582 PaintLayer* layer, 1582 PaintLayer* layer,
1583 bool needs_compositing_update) { 1583 bool needs_compositing_update) {
1584 if (PaintLayerScrollableAreaRareData* d = RareData()) { 1584 if (PaintLayerScrollableAreaRareData* d = RareData()) {
1585 d->sticky_constraints_map_.erase(layer); 1585 d->sticky_constraints_map_.erase(layer);
1586 if (needs_compositing_update && 1586 if (needs_compositing_update &&
1587 layer->GetLayoutObject().Style()->GetPosition() == EPosition::kSticky) 1587 layer->GetLayoutObject().Style()->HasStickyConstrainedPosition())
1588 layer->SetNeedsCompositingInputsUpdate(); 1588 layer->SetNeedsCompositingInputsUpdate();
1589 } 1589 }
1590 } 1590 }
1591 1591
1592 IntSize PaintLayerScrollableArea::OffsetFromResizeCorner( 1592 IntSize PaintLayerScrollableArea::OffsetFromResizeCorner(
1593 const IntPoint& absolute_point) const { 1593 const IntPoint& absolute_point) const {
1594 // Currently the resize corner is either the bottom right corner or the bottom 1594 // Currently the resize corner is either the bottom right corner or the bottom
1595 // left corner. 1595 // left corner.
1596 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be 1596 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be
1597 // the case? 1597 // the case?
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
2176 2176
2177 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2177 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2178 ClampScrollableAreas() { 2178 ClampScrollableAreas() {
2179 for (auto& scrollable_area : *needs_clamp_) 2179 for (auto& scrollable_area : *needs_clamp_)
2180 scrollable_area->ClampScrollOffsetAfterOverflowChange(); 2180 scrollable_area->ClampScrollOffsetAfterOverflowChange();
2181 delete needs_clamp_; 2181 delete needs_clamp_;
2182 needs_clamp_ = nullptr; 2182 needs_clamp_ = nullptr;
2183 } 2183 }
2184 2184
2185 } // namespace blink 2185 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698