third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 2769353002: Only create sticky position constraints for constrained sticky position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)

Patch Set: Merge with master. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index 5e53c85a0c55a915cd601708bf6e454d14848588..ee9de3c591c8be0d2835e9de6b93fe7cd5d621d3 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -216,8 +216,8 @@ bool CompositingReasonFinder::RequiresCompositingForTransformAnimation(

bool CompositingReasonFinder::RequiresCompositingForScrollDependentPosition(

const PaintLayer* layer,

bool ignore_lcd_text) const {

- if (layer->GetLayoutObject().Style()->GetPosition() != EPosition::kFixed &&

- layer->GetLayoutObject().Style()->GetPosition() != EPosition::kSticky)

+ if (!layer->GetLayoutObject().Style()->HasViewportConstrainedPosition() &&

+ !layer->GetLayoutObject().Style()->HasStickyConstrainedPosition())

return false;

if (!(ignore_lcd_text ||